Set up permissions to github workflows#218
Merged
alex merged 2 commits intocertifi:masterfrom Feb 24, 2023
joycebrum:master
Merged
Set up permissions to github workflows#218alex merged 2 commits intocertifi:masterfrom joycebrum:master
alex merged 2 commits intocertifi:masterfrom
joycebrum:master
Conversation
alex
approved these changes
Feb 23, 2023
Member
alex
left a comment
alex
left a comment
There was a problem hiding this comment.
Changes look good, but would you mind rebasing on main to pick up a fix for teh tests?
Signed-off-by: Joyce <[email protected]>
Signed-off-by: Joyce <[email protected]>
Contributor
Author
|
Done @alex and the action is working after the fix! https://github.com/joycebrum/python-certifi/actions/runs/4263462128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
contents: readto ci.yml. It seems to work with only a warn regarding python3.6 not giving support to attr: https://github.com/joycebrum/python-certifi/actions/runs/4256060098issues: writeonly to the job with no permissions in top-level. No permission has actually changed (it was onlyissues: writeby the start) but any other job added to the workflow will have no permission by default. I can change it tocontents: readif you rather.