[breaking] Comply with YARD documentation on Hash tag format#968
Merged
castwide merged 3 commits intocastwide:masterfrom Jun 28, 2025
Merged
[breaking] Comply with YARD documentation on Hash tag format#968castwide merged 3 commits intocastwide:masterfrom
castwide merged 3 commits intocastwide:masterfrom
Conversation
apiology
changed the title
2 tasks
Owner
|
I agree, it seems safe. I wouldn't expect anyone to depend on the currently broken behavior. It's just a big enough change to save for a minor release instead of a patch release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #961
This is technically a breaking change, but should be pretty safe - doesn't look like we ever parsed key types out of Hash<A, B>. Here's the spec as of 2018: 5209b49
See https://www.rubydoc.info/gems/yard/file/docs/Tags.md#hashes