Merged
Conversation
This was preventing some stdlib constants from resolving correctly. e.g., "Mutex" is an alias of the class "Thread::Mutex"
Contributor
Author
|
This was the next one in line to get a clean typecheck of the sourcegraph codebase! Looks like there's some low hanging fruit in adding more RBS AST types - I may take a crack at that. |
apiology
commented
Feb 22, 2025
| @@ -1,5 +1,7 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require 'rbs' | |||
Contributor
Author
There was a problem hiding this comment.
This was so I could get RBS class information into the Solargraph LSP as I made these changes - I can throw this in a @!parse block or something if leaving it out was intentional.
Owner
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was preventing some core/stdlib constants from resolving correctly. e.g., "Mutex" is an alias of the class "Thread::Mutex"