fix(decorators): replace super within all removed static elements#17931
Merged
Conversation
JLHwung
added
PR: Bug Fix 🐛
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61316 |
|
commit: |
nicolo-ribaudo
approved these changes
Apr 17, 2026
Member
nicolo-ribaudo
left a comment
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Can you also add a test where we make sure that the super method/getter is called with the correct this?
Contributor
Author
Added a new test, ptal. |
liuxingbaoyu
approved these changes
Apr 21, 2026
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Apr 24, 2026
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Apr 24, 2026
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Apr 24, 2026
JLHwung
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Apr 29, 2026
JLHwung
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Apr 30, 2026
JLHwung
added a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Apr 30, 2026
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we apply the
ReplaceSuperstep to all removed static class elements of a decorated class. Previously theReplaceSuperstep is only applied when a static private method contains instance private method. I believe back then this step was added merely because the test file happens to contain super property such assuper.idB. They should be applied to all removed static elements because otherwisesuperwill be resolved to the wrapper class.