Filter operationType in payload of GraphQLWsLink#12950
Merged
jerelmiller merged 4 commits intomainfrom Sep 30, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 70fd5f7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
size-limit report 📦
|
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 56709918740f98def7df7072 |
phryneas
approved these changes
Sep 30, 2025
src/link/subscriptions/index.ts
Outdated
| const { operationType, ...request } = operation; | ||
| return this.client.subscribe<ApolloLink.Result>( | ||
| { ...operation, query: print(operation.query) }, | ||
| { ...request, query: print(operation.query) }, |
Member
There was a problem hiding this comment.
What do you think - should we just be a bit more specific here and only pass in known properties?
const { query, variables, operationName, extensions} = operation;
return this.client.subscribe<ApolloLink.Result>(
{ variables, operationName, extensions, query: print(query) },
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12946
Removes the
operationTypekey in the payload sent byGraphQLWsLinkwhich was causing issues with HotChocolate.