Conversation
…ties The following vulnerabilities are fixed by pinning transitive dependencies: - https://snyk.io/vuln/SNYK-PYTHON-PROTOBUF-15090738 - https://snyk.io/vuln/SNYK-PYTHON-TORCH-15123585
Summary of ChangesHello @alejandrosuarez, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by resolving two critical vulnerabilities found in its Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, attempts to fix security vulnerabilities by upgrading protobuf and torch. However, the proposed versions are problematic. The specified protobuf version is invalid and conflicts with other dependencies, which is a critical issue. The torch version is also likely invalid and represents a major version jump that risks breaking the example code. I have left a detailed comment explaining the issues and recommend that this PR be rejected in favor of a manual and carefully tested dependency update.
| protobuf>=6.33.5 # not directly required, pinned by Snyk to avoid a vulnerability | ||
| torch>=2.10.0 # not directly required, pinned by Snyk to avoid a vulnerability |
There was a problem hiding this comment.
This automated dependency update introduces several critical issues and will likely break the project.
-
protobuf>=6.33.5: This is invalid.- The version
6.33.5does not exist for theprotobufpackage on PyPI. - Even if it were a typo for a
4.x+ version, it would conflict with other dependencies. For example,tensorboardoften requiresprotobuf<4. This would cause the installation to fail.
- The version
-
torch>=2.10.0: This is a high-risk upgrade.- The version
2.10.0does not appear to be a validtorchrelease. - The jump from
torch 1.xto2.xis a major change that can introduce breaking changes. The example script was likely not written or tested fortorch 2.x. Dependencies liketorchvisionwould also need to be updated to maintain compatibility.
- The version
Given these issues, I strongly recommend rejecting this automated PR. The vulnerabilities should be addressed with a manual update where compatible and valid package versions are chosen and thoroughly tested.
Snyk has created this PR to fix 2 vulnerabilities in the pip dependencies of this project.
Snyk changed the following file(s):
examples/custom_diffusion/requirements.txtImportant
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.