Add unit tests on file open-close management #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stankudrow
commented
Nov 11, 2024
stankudrow
commented
Nov 11, 2024
Contributor
Author
|
@ErikKalkoken, hello, could you help if possible concerning unit tests? |
stankudrow
changed the title
stankudrow
changed the title
Tinche
requested changes
Nov 11, 2024
Contributor
Author
|
https://github.com/Tinche/aiofiles/actions/runs/11785642291/job/32827865752 - tomorrow or later. |
Owner
|
Please rebase, I fixed the coverage thing on |
stankudrow
force-pushed
the
check-async-ctx-aexit
branch
from
6b242b9 to
9a407c7
Compare
Contributor
Author
|
@Tinche , good day. The PR is rebased. |
Tinche
approved these changes
Nov 12, 2024
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some tests for
__aexit__behaviour demonstration.The cause -> the issue #165 .