Handle unusual __qualname__ in inspect#3894
Merged
willmcgugan merged 1 commit intoTextualize:masterfrom Jan 23, 2026
Merged
Conversation
193795d to
0c271d5
Compare
willmcgugan
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
I discovered, that an object with an unusual
__qualname__attribute (not astr, e.g. a descriptor) causesinspectto fail.This can happen if an object is created this way intentionally, but I discovered it, when decorating a class with
@functools.lru_cachewhich forwards the underlying attributes using a descriptor when it can't add the to it's__dict__because the class uses__slots__:I fixed it by checking the type of
__qualname__falling back to__name__and if that isn't astrusing the already provided fallback.