Update CI formatting workflow: fix checkout for forked pull requests#3266
Merged
C-Achard merged 2 commits intocy/centralize-test-workflowfrom Mar 31, 2026
Merged
Update CI formatting workflow: fix checkout for forked pull requests#3266C-Achard merged 2 commits intocy/centralize-test-workflowfrom
C-Achard merged 2 commits intocy/centralize-test-workflowfrom
Conversation
2 tasks
Restrict the workflow to read-only access and prevent persisting checkout credentials. Adds permissions.contents: read and sets actions/checkout persist-credentials: false to avoid exposing the default GITHUB_TOKEN and set clear permissions.
C-Achard
approved these changes
Mar 31, 2026
Collaborator
C-Achard
left a comment
C-Achard
left a comment
There was a problem hiding this comment.
Thanks, this definitely helps!
Added some small tweaks to permissions, shouldn't change the runtime behavior.
Collaborator
Author
|
@C-Achard, Good addition! Feel free to merge in your PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
This PR fixes CI checkout failures for forked pull requests by relying on the default GitHub ref behavior instead of forcing the PR head branch. See #3220 for an example
Details:
Updated
format.yml(pre-commit workflow): changed the “Checkout PR branch” step to stop forcingref: ${{ github.head_ref }}, so pre-commit runs against the PR merge ref that always exists on the CI runner’s repository.