-
Notifications
You must be signed in to change notification settings - Fork 8.5k
fix: correct field_order in all starter project JSON templates #11727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-v1.8.0
Are you sure you want to change the base?
Conversation
The field_order arrays in starter project nodes were out of sync with the actual input definitions in the Python component source files, causing parameters to display in the wrong order in the UI. Fixed 136 nodes across 32 starter project files including Chat Input, Chat Output, Language Model, Agent, Prompt Template, Text Input, Tavily AI Search, Read File, Embedding Model, and others.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (42.10%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release-v1.8.0 #11727 +/- ##
==================================================
- Coverage 35.76% 35.21% -0.55%
==================================================
Files 1522 1521 -1
Lines 75146 72901 -2245
Branches 11305 10929 -376
==================================================
- Hits 26876 25675 -1201
+ Misses 46853 45831 -1022
+ Partials 1417 1395 -22
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Verifies that field_order arrays in starter project JSONs match the actual component input order by importing each component and comparing the relative ordering of fields.
Jira: LE-307
Summary
field_orderarrays in 136 component nodes across 32 starter project JSON filesfield_orderwas out of sync with the actualinputsdefinitions in the Python source files, causing parameters to display in the wrong order in the UItest_template_field_order_matches_component) that validatesfield_orderin all starter project JSONs against the actual component definitions, preventing future regressionsTest:
test_template_field_order_matches_componentA new backend test that runs against all 33 starter project JSON files:
metadata.module, imports the actual Python component class_get_field_order()to get the canonical input order from theinputslistfield_order(since JSON may be a subset)What it catches:
inputsdefinitionfield_orderthat don't exist in the component (they'd be filtered out, causing a mismatch)What it doesn't flag:
field_order(it's allowed to be a subset)metadata.module(e.g. note nodes)