Skip to content

Conversation

@viktoravelino
Copy link
Collaborator

@viktoravelino viktoravelino commented Feb 10, 2026

Jira: LE-307

Summary

  • Fixed field_order arrays in 136 component nodes across 32 starter project JSON files
  • The field_order was out of sync with the actual inputs definitions in the Python source files, causing parameters to display in the wrong order in the UI
  • Affected components include: Chat Input, Chat Output, Language Model, Agent, Prompt Template, Text Input, Tavily AI Search, Read File, Embedding Model, Message History, Parser, Astra DB, FAISS, MCP Connection, Split Text, API Request, Write File, and others
  • Added a new parametrized test (test_template_field_order_matches_component) that validates field_order in all starter project JSONs against the actual component definitions, preventing future regressions

Test: test_template_field_order_matches_component

A new backend test that runs against all 33 starter project JSON files:

  1. For each node with a metadata.module, imports the actual Python component class
  2. Instantiates the component and calls _get_field_order() to get the canonical input order from the inputs list
  3. Filters the component's field order to only the fields listed in the JSON's field_order (since JSON may be a subset)
  4. Verifies the relative order matches — catches cases where fields are listed in the wrong sequence

What it catches:

  • Fields listed in wrong order relative to the component's inputs definition
  • Fields in field_order that don't exist in the component (they'd be filtered out, causing a mismatch)

What it doesn't flag:

  • Missing fields from field_order (it's allowed to be a subset)
  • Nodes without metadata.module (e.g. note nodes)

The field_order arrays in starter project nodes were out of sync with
the actual input definitions in the Python component source files,
causing parameters to display in the wrong order in the UI.

Fixed 136 nodes across 32 starter project files including Chat Input,
Chat Output, Language Model, Agent, Prompt Template, Text Input,
Tavily AI Search, Read File, Embedding Model, and others.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/le-307

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 10, 2026
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 10, 2026
@viktoravelino viktoravelino self-assigned this Feb 10, 2026
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.21%. Comparing base (0f37c96) to head (8a7faa3).
⚠️ Report is 6 commits behind head on release-v1.8.0.

❌ Your project check has failed because the head coverage (42.10%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-v1.8.0   #11727      +/-   ##
==================================================
- Coverage           35.76%   35.21%   -0.55%     
==================================================
  Files                1522     1521       -1     
  Lines               75146    72901    -2245     
  Branches            11305    10929     -376     
==================================================
- Hits                26876    25675    -1201     
+ Misses              46853    45831    -1022     
+ Partials             1417     1395      -22     
Flag Coverage Δ
backend 55.68% <ø> (-0.90%) ⬇️
lfx 42.10% <ø> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added the lgtm This PR has been approved by a maintainer label Feb 11, 2026
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 11, 2026
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 11, 2026
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 11, 2026
Verifies that field_order arrays in starter project JSONs match the
actual component input order by importing each component and comparing
the relative ordering of fields.
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Feb 11, 2026
@github-actions github-actions bot added the bug Something isn't working label Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants