Skip to content

Create links: Return created links data - #347

Merged
iLLiCiTiT merged 4 commits into
developfrom
enhancement/bulk-links-create-return-output
Aug 21, 2026
Merged

Create links: Return created links data#347
iLLiCiTiT merged 4 commits into
developfrom
enhancement/bulk-links-create-return-output

Conversation

@iLLiCiTiT

Copy link
Copy Markdown
Member

Changelog Description

Return the created links from create_links method.

Testing notes:

  1. Try to call create_links and see the result.

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 21, 2026
@iLLiCiTiT iLLiCiTiT added the type: enhancement New feature or request label Aug 21, 2026
@iLLiCiTiT
iLLiCiTiT requested a review from BigRoy August 21, 2026 12:25
@BigRoy
BigRoy requested a lite review from Copilot August 21, 2026 12:34
Comment thread ayon_api/_api_helpers/links.py Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the public create_links API to return information about the links created by the bulk-create request, aligning behavior with the PR’s stated goal of exposing created-link results to callers.

Changes:

  • Change create_links return type from None to a list of created-link records.
  • Implement return values for both the bulk endpoint (newer servers) and the per-link fallback loop (older servers).
  • Adjust empty-input behavior to return an empty list instead of None.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
ayon_api/_api.py Updates the top-level create_links wrapper signature to return created-link results from the connection helper.
ayon_api/_api_helpers/links.py Implements returning created-link data for both bulk and fallback code paths, including empty-input behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines 274 to 281
Args:
project_name (str): Project where links are created.
links (list[CreateLinkData]): List of link data.

Raises:
ValueError: Link data is invalid.

"""
Comment thread ayon_api/_api_helpers/links.py
Comment thread ayon_api/_api.py Outdated
Comment thread ayon_api/_api.py
@iLLiCiTiT iLLiCiTiT changed the title Create links: Create links: Return created links data Aug 21, 2026

@BigRoy BigRoy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. ✅

Check this please: #347 (comment)

@BigRoy
BigRoy self-requested a review August 21, 2026 12:46
@iLLiCiTiT
iLLiCiTiT merged commit 78c1639 into develop Aug 21, 2026
3 checks passed
@iLLiCiTiT
iLLiCiTiT deleted the enhancement/bulk-links-create-return-output branch August 21, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants