This repository was archived by the owner on Mar 26, 2018. It is now read-only.
Store filerev summary to file and strip summary paths#78
Open
eversteini wants to merge 5 commits intoyeoman:masterfrom
Open
Store filerev summary to file and strip summary paths#78eversteini wants to merge 5 commits intoyeoman:masterfrom
eversteini wants to merge 5 commits intoyeoman:masterfrom
Conversation
tasks/filerev.js
Outdated
|
Hi, any updates on this? @eversteini @kevva I found these features really useful and having them merged would be great 🙏 |
|
I would also like to have this feature merged. I am using the fork from @eversteini at the moment. @kevva ? |
Author
|
We are now working with this additional feature since more than a year and everything is working fine. It would be cool if this could be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature offers two possibility:
Therefore two option parameters are supported:
summaryFilePath defines the path, where the filerev summary should be stored.
stripPath can be used to strip the src/dest summary paths. The value can either be a string, or an object with the properties src and dest. If only a string is passed, this string is removed from all src and dest paths. If an object is passed, src and dest paths get treated individually.
Example:
My use-case:
I implemented this feature because I needed the filerev summary in a view helper to provide the hashed source path when a view gets loaded. Therefore the summary had to be stored somewhere locally.