ci: test with node 6 once 6.4.0 is patched#602
Merged
Conversation
Contributor
|
btw, I know this isn’t communicated suuuper-well, but Node v5 is already past its end of life, as far as Node core is concerned. |
Member
Author
|
@addaleax Hmm, good point. I'll drop Node 5 with this too. 👍 |
Contributor
|
v6.5.0 is out, so kicking off a new CI with this should return everything to green :) |
Member
Author
|
@addaleax Thanks for the heads up, will push a new commit dropping Node 5 very soon. |
nexdrew
force-pushed
the
back-to-the-future-node6
branch
from
834c08a to
ccc0309
Compare
Member
Author
|
Looks like it's gonna fail with Node 6.5.0 since the Function descriptors now include the inferred function name (e.g. Time to relax the regex methinks. |
Contributor
|
Oh, yeah, I forgot that… the Node.js core tests had to be fixed up for that, too. You’re probably right. |
Member
Author
Member
|
Great, thanks @nexdrew 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the Travis and AppVeyor changes deliberately introduced with #597.
It is expected that tests with Node 6 will fail until version 6.4.0 is patched with this reversion: nodejs/node#8143
This PR serves as a reminder to revert the temporary testing change pinned to Node 6.3.1.
Fixes #596.
Thanks to @maxrimue for originally reporting the error, and thanks to @addaleax for fixing our tests with citgm and AppVeyor!