Skip to content

Python 3 support#21

Merged
wrobstory merged 2 commits intopython-visualization:masterfrom
tbicr:test-fix
Sep 21, 2014
Merged

Python 3 support#21
wrobstory merged 2 commits intopython-visualization:masterfrom
tbicr:test-fix

Conversation

@tbicr
Copy link

@tbicr tbicr commented May 1, 2014

No description provided.

@tbicr tbicr changed the title Fix tests, remove duplicated and outdated (obsolete) test templates Python 3 support May 2, 2014
@wrobstory
Copy link
Contributor

Out of town, will review next week

@ahmadia ahmadia mentioned this pull request May 15, 2014
@psychemedia
Copy link

I'd like to +1 on a PR for python 3 support - I'm currently getting issues trying to install to python 3.3

ImportError                               Traceback (most recent call last)
<ipython-input-6-af6e4f19ef00> in <module>()
----> 1 import folium

/usr/local/lib/python3.3/dist-packages/folium/__init__.py in <module>()
      1 # -*- coding: utf-8 -*-
----> 2 from folium import Map

ImportError: cannot import name Map

@tbicr
Copy link
Author

tbicr commented May 15, 2014

@psychemedia, it not merged yet, so in my branch now:

from folium.folium import Map, initialize_notebook

Temporary you can try install from my branch:

pip install git+https://github.com/tbicr/folium.git@fixed#folium

@psychemedia
Copy link

@tbicr thanks. Will give it a go now... [quick tests seem to work ok]

@wrobstory
Copy link
Contributor

Ok @tbicr , sorry to be a pain, but could you do me a favor and rebase your PRs back onto master? I should have merged this in before I merged anything else, but it's too late now. Also, if you just want to combine all three PRs into one mega-PR, I'll just test and pull the whole thing in.

If any of the latest merges have broken tests, dont worry about it- I'll fix them after merging this in.

@tbicr
Copy link
Author

tbicr commented May 23, 2014

rebased

@psychemedia psychemedia mentioned this pull request Jul 22, 2014
wrobstory added a commit that referenced this pull request Sep 21, 2014
@wrobstory wrobstory merged commit 0e3de3b into python-visualization:master Sep 21, 2014
@wrobstory
Copy link
Contributor

Merged.

FINALLY.

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants