Skip to content

Update tsconfig.json presets for TS 5.0#7785

Merged
Princesseuh merged 4 commits intonextfrom
feat/5.0-tsconfig
Jul 26, 2023
Merged

Update tsconfig.json presets for TS 5.0#7785
Princesseuh merged 4 commits intonextfrom
feat/5.0-tsconfig

Conversation

@Princesseuh
Copy link
Member

Changes

TypeScript has this annoying behaviour where if you use an unknown compiler option, it'll.. completely refuse to do anything. I feel like they could've just added a warning instead, but whatever. This PR adds cool new options like verbatimModuleSyntax and updates it to use moduleResolution: 'bundler', unlocking supports for the exports field. It's neat

Testing

Tested manually

Docs

N/A, we don't document this

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

🦋 Changeset detected

Latest commit: a956e4e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 24, 2023
…p people avoid weird bundling issues and save people time.
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be merged to the next branch?

@Princesseuh Princesseuh changed the base branch from main to next July 25, 2023 09:51
@ematipico ematipico force-pushed the next branch 2 times, most recently from 1be3605 to d8ae80b Compare July 26, 2023 12:46
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's 🚢 it!

@howagain
Copy link

I'm seeing a behavior on webstorm where "allowImportingTsExtensions": true is adding the .tsx extension automatically. It seems like a bug on their side but why is it included in the base tsConfig for astro? I don't see any discussion over that decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: astro Related to the core `astro` package (scope)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants