fix(inbox): fallback to leader inbox when caller is not a team member - #69

Thanks for the quick fix. I tested this locally in a clean temp checkout, and it is not merge-ready yet.

Blocking:

• ruff check clawteam/ tests/ fails because the new code calls click.echo(...) but click is not imported in clawteam/cli/commands.py. Any non-member fallback path will raise NameError at runtime.
• Same block also leaves trailing whitespace on the inserted blank lines.

Validation run:

python3 -m venv .venv
.venv/bin/python -m pip install -e ".[dev]"
.venv/bin/ruff check clawteam/ tests/
# F821 Undefined name `click` at commands.py:679,682,721,724
# W293 blank line contains whitespace at 673,683,715,725

Suggested fix: use the existing Typer/Rich output path instead of introducing click, or import click explicitly and remove the trailing whitespace. Please also add regression coverage for both inbox receive and inbox peek non-member fallback before merge.

Thanks for the quick turnaround. Ran the test suite locally on e48dcaf — there are still two blocking issues:

1. Logic bug — member check input is wrong (commands.py:674-675, 716-717)

TeamManager.resolve_inbox returns the inbox directory name (e.g. alice_leader), not the logical member name (leader). Feeding that into TeamManager.get_member always returns None, so the fallback branch triggers for every caller, including the leader themselves. This breaks the existing test_inbox_peek_defaults_to_resolved_member_inbox test.

Suggested fix — do the member check before resolving:

identity = AgentIdentity.from_env()
caller_name = agent or identity.agent_name
member = TeamManager.get_member(team, caller_name, identity.user)
if member is None:
    leader_inbox = TeamManager.get_leader_inbox(team)
    if leader_inbox:
        error_console.print(f"[yellow][info][/yellow] caller '{caller_name}' 非团队成员，回退到 leader '{leader_inbox}' 的 inbox")
        agent_name = leader_inbox
    else:
        error_console.print(f"[yellow][warn][/yellow] caller '{caller_name}' 非团队成员且 team 无 leader 配置，使用 --agent 指定接收方")
        agent_name = TeamManager.resolve_inbox(team, caller_name, identity.user)
else:
    agent_name = TeamManager.resolve_inbox(team, caller_name, identity.user)

2. console.print(file=sys.stderr) raises TypeError (commands.py:679,682,721,724)

Rich Console.print doesn't accept a file kwarg. Reproduced:

$ python -c "from rich.console import Console; import sys; Console().print('x', file=sys.stderr)"
TypeError: Console.print() got an unexpected keyword argument 'file'

Cleanest fix: add error_console = Console(stderr=True) near the existing console = Console() (line 23) and use it for the 4 fallback messages — drop file=sys.stderr.

Test verification

.venv/bin/ruff check clawteam/ tests/    # All checks passed
.venv/bin/python -m pytest tests/ -v
# 1 failed, 481 passed, 9 skipped
# FAILED tests/test_inbox_routing.py::test_inbox_peek_defaults_to_resolved_member_inbox

So ruff does pass — but please run pytest too before pushing the next revision.

Regression tests

About the test scaffolding question — tests/test_inbox_routing.py:43 (test_inbox_peek_defaults_to_resolved_member_inbox) is the right anchor; it uses CliRunner + monkeypatch to invoke the CLI command. After the fix, please add two cases following the same pattern:

1. Non-member caller (e.g., a main agent whose name isn't in the team) calls inbox receive — should fallback to leader's inbox and see the message originally sent to the leader.
2. Team without a leader config — should print the warn line and not consume any messages.

The existing leader peek test should also keep passing once Blocking #1 is fixed.

Thanks!

Thanks for the fixes — re-reviewed the full branch on a clean checkout (878cd21).

The inbox fix itself is now correct. Both blocking issues from my last review are resolved: the member check now runs on caller_name before resolve_inbox, and the four stderr messages use error_console = Console(stderr=True). The previously broken test_inbox_peek_defaults_to_resolved_member_inbox passes. Nice work on 73c3b1e.

However, the branch is not mergeable in its current state, for two reasons:

1. Scope — please split the two unrelated commits into their own PRs

10e85b7 (dual workspace feature, +183) and 878cd21 (spawn reliability fixes, +66) have nothing to do with the inbox fallback fix this PR is titled for. They're substantial changes that each deserve their own review — and right now the spawn commit is actually red on this branch:

ruff:   F541 clawteam/spawn/prompt.py:149 (f-string without placeholders)
        N806 clawteam/spawn/tmux_backend.py:125 (_ESSENTIAL_ENV_KEYS in function)
pytest: 4 failed, 478 passed, 9 skipped
        FAILED test_tmux_backend_exports_spawn_path_for_agent_commands
        FAILED test_tmux_backend_waits_for_pane_before_declaring_failure
        FAILED test_tmux_backend_qwen_skip_permissions_and_prompt
        FAILED test_tmux_backend_opencode_skip_permissions_and_prompt

The failures come from the env whitelist change: it now drops application-level variables like GOOGLE_CLOUD_PROJECT that spawned agents legitimately need (and that tests assert on). That's a behavior question worth its own discussion in a dedicated PR — a hard-coded 15-key whitelist will silently strip API keys and cloud config from user environments. (The commit message says "tests: 482 passed", but that was before 878cd21 landed on top.)

Suggested split:

• This PR → keep feefde9 + e48dcaf + 73c3b1e (inbox fix only)
• New PR → dual workspace feature
• New PR → spawn reliability fixes (with the ruff/pytest issues addressed and the whitelist behavior explained)

2. The regression tests from the last review are still missing

tests/test_inbox_routing.py is untouched. As requested previously, please add the two cases (same CliRunner + monkeypatch pattern as test_inbox_peek_defaults_to_resolved_member_inbox):

1. Non-member caller runs inbox receive → falls back to the leader's inbox and receives the leader-addressed message
2. Team without leader config → prints the warn line and consumes nothing

Once this branch is trimmed to the inbox commits + those two tests, it's ready to merge. The other two commits I'm happy to review promptly as separate PRs.