Use GTK compat function with WEBVIEW_HINT_FIXED#1322
Merged
SteffenL merged 1 commit intowebview:masterfrom Jul 1, 2025
Merged
Conversation
gtk_widget_set_size_request() was called when WEBVIEW_HINT_FIXED was passed into webview_set_size(). That function is meant to set a minimum size. Instead we can call gtk_window_set_default_size() (GTK 4) or gtk_window_resize() (GTK 3).
SteffenL
added
the
type: improvement
snuk182
pushed a commit
to snuk182/webview
that referenced
this pull request
Sep 12, 2025
gtk_widget_set_size_request() was called when WEBVIEW_HINT_FIXED was passed into webview_set_size(). That function is meant to set a minimum size. Instead we can call gtk_window_set_default_size() (GTK 4) or gtk_window_resize() (GTK 3).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gtk_widget_set_size_request()was called whenWEBVIEW_HINT_FIXEDwas passed intowebview_set_size(). That function is meant to set a minimum size.Instead we can call
gtk_window_set_default_size()(GTK 4) orgtk_window_resize()(GTK 3).