Merged
Conversation
since node 16.6 webpack-cli fails to load esm config unless WEBPACK_CLI_FORCE_LOAD_ESM_CONFIG=true see: nodejs/node#39175 see: https://github.com/webpack/webpack-cli/blob/a660ffcbeb2807bce1554f787297e697464abd59/packages/webpack-cli/lib/webpack-cli.js#L50-L51 License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <[email protected]>
Member
|
Amaze, can you revert the changes to the github actions to pin the node version to 16.5? |
vasco-santos
approved these changes
Jul 30, 2021
Member
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
LGTM
Needs revert on Node version CI
Contributor
Author
|
Wat! That landed already!? |
License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <[email protected]>
alanshaw
approved these changes
Jul 30, 2021
johndmulhausen
pushed a commit
that referenced
this pull request
Aug 6, 2021
Since node v16.6 webpack-cli fails to load esm config unless WEBPACK_CLI_FORCE_LOAD_ESM_CONFIG=true see: nodejs/node#39175 see: https://github.com/webpack/webpack-cli/blob/a660ffcbeb2807bce1554f787297e697464abd59/packages/webpack-cli/lib/webpack-cli.js#L50-L51 License: (Apache-2.0 AND MIT) Signed-off-by: Oli Evans <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since node 16.6 webpack-cli fails to load esm config unless WEBPACK_CLI_FORCE_LOAD_ESM_CONFIG=true
see: nodejs/node#39175
see: https://github.com/webpack/webpack-cli/blob/a660ffcbeb2807bce1554f787297e697464abd59/packages/webpack-cli/lib/webpack-cli.js#L50-L51
License: (Apache-2.0 AND MIT)
Signed-off-by: Oli Evans [email protected]