fix(runner): remove redundant module.instantiate calls#5743
Merged
chenjiahan merged 3 commits intomainfrom Aug 2, 2025
Merged
Conversation
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes redundant module.instantiate() calls from the module runners, as this method was removed from Node.js starting with version 13.0.0. The changes clean up outdated code that is no longer needed.
- Removes deprecated
module.instantiate()calls from ESM and synthetic module runners - Improves variable naming in the
asModulefunction for better clarity - Simplifies code structure by removing unnecessary conditional instantiate calls
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/server/runner/esm.ts | Removes redundant esm.instantiate() call that is no longer needed |
| packages/core/src/server/runner/asModule.ts | Removes m.instantiate() call and improves variable naming from m to syntheticModule |
Comments suppressed due to low confidence (1)
packages/core/src/server/runner/asModule.ts:32
- The removal of the
instantiate()call should be covered by tests to ensure the module evaluation still works correctly without it, especially since this is a breaking change from older Node.js versions.
await syntheticModule.evaluate();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove redundant
module.instantiate()calls in the module runners.module.instantiatehas been removed since Node.js >= 13.0.0.Related Links
Checklist