Add support for RFC3779 X509 extensions for IPs and AS-IDs#245
Open
niklbird wants to merge 4 commits intowbond:masterfrom
Open
Add support for RFC3779 X509 extensions for IPs and AS-IDs#245niklbird wants to merge 4 commits intowbond:masterfrom
niklbird wants to merge 4 commits intowbond:masterfrom
Conversation
Owner
|
Looks like you need to fix some linting errors |
Author
Thank you! I fixed them now :) |
Author
|
Hey :) Is there anything still missing that you need? |
Owner
|
Could you rebase this on master? |
Owner
|
Thanks for taking the time to add these. Overall it looks good. The one style change I would request is that for this project we use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.