Define the time origin for service workers#1621
Merged
jakearchibald merged 1 commit intow3c:mainfrom Jan 25, 2022
Merged
Conversation
In [this HTML PR](whatwg/html#7339) we add a `time origin` getter to the `environment settings object`. We need to account for that value in service workers, which would be the time the worker environment is created.
3 tasks
domenic
pushed a commit
to whatwg/html
that referenced
this pull request
Nov 29, 2021
The time origin, which is the epoch for all performance timeline APIs, was previously defined in https://w3c.github.io/hr-time/#dfn-time-origin. This makes its computation explicit, without changing its current definition and behavior. Notably: * "time origin becomes an environment settings object algorithm, computed differently for windows vs. worker scopes. * The 4 places where this timestamp is set are creation of an about:blank browsing context, the beginning of navigation, the confirmation of an unload prompt, and the creation of a worker. * The timestamp is a "shared monotonic clock" value, which is defined in HR-TIME (and internally in ECMAScript). As part of this PR, also refactored unload prompts to return a result rather than rely on a somewhat hand-wavy "refused to allow" property. See w3c/hr-time#131 and w3c/navigation-timing#166. See also w3c/ServiceWorker#1621.
jakearchibald
approved these changes
Jan 17, 2022
Contributor
jakearchibald
left a comment
jakearchibald
left a comment
There was a problem hiding this comment.
LGTM. The IPR check is failing - you dealt with that stuff right? I guess this PR was just before that happened?
Contributor
Author
I kept getting specific-patch approvals for IPR, never got one for this one. I can also join the WG as an individual if that's preferred. |
Contributor
Contributor
Author
Contributor
|
I'll land this now and we can deal with the fallout later. |
Member
|
Usually there is a tool that provide a link to make it work magically, looks like it didn't work this time :( |
Contributor
Author
Great! How do I do that? |
Member
mfreed7
pushed a commit
to mfreed7/html
that referenced
this pull request
Jun 3, 2022
The time origin, which is the epoch for all performance timeline APIs, was previously defined in https://w3c.github.io/hr-time/#dfn-time-origin. This makes its computation explicit, without changing its current definition and behavior. Notably: * "time origin becomes an environment settings object algorithm, computed differently for windows vs. worker scopes. * The 4 places where this timestamp is set are creation of an about:blank browsing context, the beginning of navigation, the confirmation of an unload prompt, and the creation of a worker. * The timestamp is a "shared monotonic clock" value, which is defined in HR-TIME (and internally in ECMAScript). As part of this PR, also refactored unload prompts to return a result rather than rely on a somewhat hand-wavy "refused to allow" property. See w3c/hr-time#131 and w3c/navigation-timing#166. See also w3c/ServiceWorker#1621.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this HTML PR we add
a
time origingetter to theenvironment settings object.We need to account for that value in service workers, which would be the
time the worker environment is created.
Preview | Diff