Skip to content

jason add max cooldown times label#84

Open
Jason-Liu-Dream wants to merge 1 commit intovolcano-sh:masterfrom
Jason-Liu-Dream:feature/7-upgrade-cdp
Open

jason add max cooldown times label#84
Jason-Liu-Dream wants to merge 1 commit intovolcano-sh:masterfrom
Jason-Liu-Dream:feature/7-upgrade-cdp

Conversation

@Jason-Liu-Dream
Copy link

@Jason-Liu-Dream Jason-Liu-Dream commented Jul 19, 2022 •
edited
Loading

related to volcano pr #2363
add a new label "volcano.sh/max-cooldown-times" to indicate cool down time for preempted

jason add max cooldown times label
d20d32d 
Signed-off-by: 刘毅（Jason Liu） <[email protected]>
@volcano-sh-bot
Copy link
Collaborator

volcano-sh-bot commented Jul 19, 2022

Welcome @Jason-Liu-Dream!

It looks like this is your first PR to volcano-sh/apis 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot
Copy link
Collaborator

volcano-sh-bot commented Jul 19, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign wpeng102
You can assign the PR to them by writing /assign @wpeng102 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jason-Liu-Dream Jason-Liu-Dream mentioned this pull request Jul 19, 2022
Closed
@Jason-Liu-Dream
Copy link
Author

Jason-Liu-Dream commented Jul 19, 2022

/assign @william-wang

@Thor-wl Thor-wl requested review from Thor-wl, hwdef, qiankunli, shinytang6 and wpeng102 and removed request for kevin-wangzefeng July 19, 2022 08:24
@volcano-sh-bot
Copy link
Collaborator

volcano-sh-bot commented Oct 22, 2025

@Jason-Liu-Dream: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@william-wang william-wang Awaiting requested review from william-wang

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

@hwdef hwdef Awaiting requested review from hwdef

@qiankunli qiankunli Awaiting requested review from qiankunli

@shinytang6 shinytang6 Awaiting requested review from shinytang6

@wpeng102 wpeng102 Awaiting requested review from wpeng102

Assignees

@william-wang william-wang

Labels

needs-rebase size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jason-Liu-Dream @volcano-sh-bot @william-wang