Skip to content

refactor(fspy-shm): expose explicit backing-file removal - #642

Draft
wan9chi wants to merge 1 commit into
feat/fspy-shm-sigsafe-createfrom
feat/fspy-shm-sigsafe-unlink
Draft

refactor(fspy-shm): expose explicit backing-file removal#642
wan9chi wants to merge 1 commit into
feat/fspy-shm-sigsafe-createfrom
feat/fspy-shm-sigsafe-unlink

Conversation

@wan9chi

@wan9chi wan9chi commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

Callers already retain the full shared-memory backing path, so ShmKeeper duplicated path ownership and hid cleanup failures behind Drop. Return the handle directly and expose a fallible remove operation instead, making backing-file lifetime explicit and keeping the eventual injected-runtime API borrowed and allocation-free.

@github-actions

github-actions Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

fspy benchmark

linux

dynamic/launch             change  +0.87%  [ -6.20% ..  +7.84%]  overhead   +67.66%
dynamic/access             change  -0.57%  [-18.39% .. +11.54%]  overhead    +5.60%
dynamic/access-relative    change  +0.07%  [-14.66% .. +22.23%]  overhead   +51.83%
static/launch              change  +1.27%  [ -8.01% .. +10.71%]  overhead  +189.59%
static/access              change  -0.16%  [-10.41% .. +10.87%]  overhead  +736.76%
static/access-relative     change  -0.29%  [ -5.85% ..  +7.50%]  overhead  +942.02%

macos

dynamic/launch             change  +0.44%  [ -4.17% ..  +5.30%]  overhead  +220.16%
dynamic/access             change  -0.94%  [-20.75% .. +21.26%]  overhead    +7.74%
dynamic/access-relative    change  +0.43%  [ -6.39% ..  +8.45%]  overhead  +244.51%

windows

dynamic/launch             change  -0.80%  [ -4.07% ..  +3.91%]  overhead   +27.32%
dynamic/access             change  +0.19%  [ -0.78% ..  +0.97%]  overhead    +1.37%
dynamic/access-relative    change  +0.19%  [ -0.95% ..  +1.28%]  overhead    +0.98%

@wan9chi
wan9chi force-pushed the feat/fspy-shm-sigsafe-unlink branch 2 times, most recently from cd36e35 to f578304 Compare August 11, 2026 03:25
@wan9chi
wan9chi force-pushed the feat/fspy-shm-sigsafe-unlink branch from f578304 to c1f27ca Compare August 11, 2026 04:24
@wan9chi
wan9chi force-pushed the feat/fspy-shm-sigsafe-unlink branch from c1f27ca to ec93753 Compare August 11, 2026 05:14
@wan9chi wan9chi changed the title refactor(fspy-shm): unlink Unix backing files through sigsafe refactor(fspy-shm): expose explicit backing-file removal Aug 11, 2026
@wan9chi wan9chi mentioned this pull request Aug 11, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

1 participant

@wan9chi