Skip to content

refactor(fspy-shm): make Unix implementation no-std - #641

Draft
wan9chi wants to merge 1 commit into
refactor/fspy-shm-path-typefrom
feat/fspy-shm-platform-errors
Draft

refactor(fspy-shm): make Unix implementation no-std#641
wan9chi wants to merge 1 commit into
refactor/fspy-shm-path-typefrom
feat/fspy-shm-platform-errors

Conversation

@wan9chi

@wan9chi wan9chi commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

The injected runtime cannot rely on Rust std or libc initialization. Unix fspy_shm already performs every operation through sigsafe, so exposing std::io::Error and retaining std implementation types is unnecessary. Use sigsafe Error and Result aliases, core types, and a crate-level Unix no_std guard; Windows keeps its std::io API.

@github-actions

github-actions Bot commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown

fspy benchmark

linux

dynamic/launch             change  +0.33%  [ -6.10% ..  +7.86%]  overhead   +50.86%
dynamic/access             change  -0.53%  [ -5.80% ..  +1.13%]  overhead    +7.14%
dynamic/access-relative    change  -0.58%  [ -9.51% ..  +1.03%]  overhead   +46.73%
static/launch              change  +1.62%  [ -9.12% .. +12.41%]  overhead  +142.76%
static/access              change  +0.18%  [-10.40% ..  +9.50%]  overhead  +825.90%
static/access-relative     change  -0.46%  [ -2.30% ..  +2.70%]  overhead +1331.17%

macos

dynamic/launch             change  +0.25%  [ -2.72% ..  +3.09%]  overhead  +220.79%
dynamic/access             change  +1.10%  [ -3.90% ..  +5.09%]  overhead    +5.54%
dynamic/access-relative    change  +0.00%  [ -2.92% ..  +3.44%]  overhead  +251.20%

windows

dynamic/launch             change  +2.57%  [ -5.34% .. +10.11%]  overhead   +27.03%
dynamic/access             change  -0.53%  [ -2.64% ..  +1.81%]  overhead    +1.68%
dynamic/access-relative    change  -0.85%  [-18.10% ..  +6.71%]  overhead    +1.75%

@wan9chi
wan9chi force-pushed the feat/fspy-shm-platform-errors branch from 2283943 to 6c6859e Compare August 11, 2026 03:25
@wan9chi
wan9chi changed the base branch from feat/fspy-shm-sigsafe-mmap to feat/fspy-shm-sigsafe-unlink August 11, 2026 03:25
@wan9chi
wan9chi force-pushed the feat/fspy-shm-platform-errors branch from 6c6859e to 3c0970b Compare August 11, 2026 04:24
@wan9chi
wan9chi force-pushed the feat/fspy-shm-platform-errors branch from 3c0970b to db13cf2 Compare August 11, 2026 05:15
@wan9chi
wan9chi changed the base branch from feat/fspy-shm-sigsafe-unlink to refactor/fspy-shm-path-type August 11, 2026 05:17
@wan9chi
wan9chi force-pushed the feat/fspy-shm-platform-errors branch from db13cf2 to e07614c Compare August 11, 2026 08:40
@wan9chi
wan9chi force-pushed the feat/fspy-shm-platform-errors branch from e07614c to 784a715 Compare August 11, 2026 08:46
@wan9chi wan9chi changed the title refactor(fspy-shm): expose platform error types refactor(fspy-shm): make Unix implementation no-std Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

See More

Successfully merging this pull request may close these issues.

1 participant

@wan9chi