Fix to Update WebAPI to Case Lowered HTTP Headers#766
Closed
candiedoperation wants to merge 1 commit intoveyon:4.6from
Closed
Fix to Update WebAPI to Case Lowered HTTP Headers#766candiedoperation wants to merge 1 commit intoveyon:4.6from
candiedoperation wants to merge 1 commit intoveyon:4.6from
Conversation
Author
|
@tobydox, requesting you to please merge this pull request to implement the HTTP Headers in Veyon 4.6's Code |
Member
|
Thank you for identifying and reporting this issue! Indeed this required a fix to properly implement case insensitive header field lookups - see 5d3e5a6 for details. Just changing to lower case would break existing applications which send requests with upper case characters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #767 for Branch 4.6
https://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.2
https://www.rfc-editor.org/rfc/rfc7230#appendix-A.2
HTTP Headers are Case Insensitive. Maximum HTTP Libraries in
JavaScript (XHR, Axios, fetch) convert HTTP Headers' to Lowercase
and Veyon fails to authenticate as the below code (before this edit)
returns QStringLiteral("Connection-Uid") instead of all lowercase
QStringLiteral("connection-uid")
This issue in Veyon was discovered during development of an Android/iOS
Client for Veyon at https://github.com/candiedoperation/Monitoring-Center