fix: Align dry run cache status with normal run by checking caching guards#12448
Merged
anthonyshew merged 1 commit intomainfrom Mar 26, 2026
Merged
fix: Align dry run cache status with normal run by checking caching guards#12448anthonyshew merged 1 commit intomainfrom
anthonyshew merged 1 commit intomainfrom
Conversation
…uards TaskCache::exists() (used by --dry) was missing the caching_disabled and reads_disabled guard checks that restore_outputs() (used by normal runs) performs. This caused --dry=json to report incorrect cache status when cache:false was set or reads were disabled. Closes #9044
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions bot
added a commit
that referenced
this pull request
Mar 26, 2026
## Release v2.8.21-canary.11 Versioned docs: https://v2-8-21-canary-11.turborepo.dev ### Changes - release(turborepo): 2.8.21-canary.10 (#12446) (`014111c`) - fix: Align dry run cache status with normal run by checking caching guards (#12448) (`48aa171`) Co-authored-by: Turbobot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TaskCache::exists()(used by--dry) was missing thecaching_disabledandreads_disabledguard checks thatrestore_outputs()(used by normal runs) performs. This caused--dry=jsonto report incorrect cache status whencache: falsewas set on a task or when cache reads were globally disabled.cache: falseis configured.Closes #9044