Conversation
…nt. And have no default for state. I think Australians would prefer it this way, even though technically ACT and NT are territories, not states.
1 similar comment
|
Better not break compatibility with past versions. Also, please double-check Travis build errors (note: python version issues should be fixed now). Thx! |
|
Hi, Thanks for the AU updates and PR. Non of my business but just curiosity; why would you have another python-holidays unforked clone in your account that actually have different name and license file? |
|
Hi,
you're welcome.
In fact, I have a *forked *(see
https://github.com/dr-prodigy/python-holidays) python-holidays project,
because I started coding there until lately.
Then I've been added to the main repo today by ryanss, so I started pushing
there to release my work.
Have a nice day!
dr.p
2018-01-14 15:38 GMT+01:00 kirpit <[email protected]>:
… Hi,
Thanks for the AU updates and PR.
Non of my business but just curiosity; why would you have another
python-holidays *unforked* clone in your account that actually have
different name and license file?
ba16a1f5aa8b352a90aee67b81d2c4fb52a02dcf
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Aa6OcSmZaItpD2djoiKOsnogIKu1yLyXks5tKhFpgaJpZM4NUY3D>
.
|
|
Oh no, sorry for the confusion. My question was to @linuxsoftware about his repo
Why would you end someone's copyright ownership and make yourself the IP owner? |
|
@kirpit : Hi, I created ls.holidays as python-holidays seemed to be no longer being maintained. I acknowledge that it is a fork of python-holidays by ryanss in the README file. In the LICENSE file I recorded that copyright was shared with ryanss for his work from 2014-2017 and that the work I was doing was copyright by me. IANAL, but Ryanss retains his copyright ownership - and would do regardless of any edit to the LICENSE file. The license remains as the MIT license. FYI It is not unusual for a project which has a bit of history to have multiple copyrights. Now that python-holidays has a new lease of life I don't need ls.holidays. But I suggest to dr.p that splitting the holidays by country as I did in ls.holidays could make it easier to handle merges for people like me who aren't so hot with Git. Hope that explains things. |
|
@linuxsoftware
Okay..
About code structure, apart from not-so-keen-of-git people, I was already
convinced that, due to the current number of countries already managed, it
would be useful to refactor holiday.py module to keep things maintainable.
Will be done, thx ;)
About your fork-no-fork, I don't think you're doing anything so bad..
OTOH if you feel like you want to go further in the project, I'd suggest
you better get back to the mainstream one, so efforts are not scattered and
everyone will take advantage of all our work in a single lib.
Please let us know, thx
Il 16 gen 2018 8:20 AM, "David Moore" <[email protected]> ha scritto:
@kirpit <https://github.com/kirpit> : Hi, I created ls.holidays as
python-holidays seemed to be no longer being maintained. I acknowledge that
it is a fork of python-holidays by ryanss in the README file. In the
LICENSE file I recorded that copyright was shared with ryanss for his work
from 2014-2017 and that the work I was doing was copyright by me. IANAL,
but Ryanss retains his copyright ownership - and would do regardless of any
edit to the LICENSE file. The license remains as the MIT license. FYI It is
not unusual for a project which has a bit of history to have multiple
copyrights.
Now that python-holidays has a new lease of life I don't need ls.holidays.
But I suggest to dr.p that splitting the holidays by country as I did in
ls.holidays could make it easier to handle merges for people like me who
aren't so hot with Git.
Hope that explains things.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Aa6OcZ1Wtya4rjmRmokevWqcRHLTxgoUks5tLE20gaJpZM4NUY3D>
.
|
4 participants
I am the one who created the Australia country class with it taking a prov argument. Now that the library is much more developed and HolidayBase can also take a state argument I think Australians would prefer to use that (even though ACT and NT are territories, not states). I have changed this, and have also removed ACT as a default, and fixed the handling of Canberra Day and Family & Community Day for ACT.
NOTE: I have not made any attempt at maintaining backwards compatibility. Is this required? If so I could add some code for that.