Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: v8/v8
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7.0.276.22
Choose a base ref
...
head repository: v8/v8
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7.0.276.24
Choose a head ref
  • 4 commits
  • 5 files changed
  • 3 contributors

Commits on Oct 1, 2018

  1. Merged: [wasm] Notify StreamingDecoder when its AsyncCompileJob is de…

    …structed
    
    The lifetime of the AsyncCompileJob does not depend on the lifetime of
    the stream which feeds data into it. Multiple checks guarantee that the
    AsyncCompileJob still exists when the stream wants to call it. With
    this CL we add an additional level of defense to make sure that
    streaming does not continue after the AsyncCompileJob got destructed.
    
    It is not clear if this CL fixes the bug referenced below. However, the
    crashes there could be caused when streaming accesses the
    AsyncCompileJob after it got destructed already. I was not able though
    to find a scenario where this is possible.
    
    R=​[email protected]
    NOTRY=true
    NOPRESUBMIT=true
    NOTREECHECKS=true
    
    Bug: chromium:888170
    Change-Id: Id5c6cc34842735a3adaf3e09c57cbe923cfc2630
    Reviewed-on: https://chromium-review.googlesource.com/1241961
    Commit-Queue: Andreas Haas <[email protected]>
    Reviewed-by: Clemens Hammacher <[email protected]>
    Cr-Original-Commit-Position: refs/heads/master@{#56213}(cherry picked from commit 1a5a6c3)
    Reviewed-on: https://chromium-review.googlesource.com/1253602
    Cr-Commit-Position: refs/branch-heads/7.0@{#47}
    Cr-Branched-From: 6e2adae-refs/heads/7.0.276@{#1}
    Cr-Branched-From: bc08a86-refs/heads/master@{#55424}
    gahaas authored and Commit Bot committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    5dc88f0 View commit details
    Browse the repository at this point in the history
  2. Version 7.0.276.23

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com
    
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: Ib228d603040c8c90338371203a5b4cecbee0b3bc
    Reviewed-on: https://chromium-review.googlesource.com/1252777
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/branch-heads/7.0@{#48}
    Cr-Branched-From: 6e2adae-refs/heads/7.0.276@{#1}
    Cr-Branched-From: bc08a86-refs/heads/master@{#55424}
    V8 Autoroll committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    8d4a276 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. Put back deleted V8_DEPRECATE_SOON methods

    This partially reverts
    https://chromium-review.googlesource.com/c/v8/v8/+/1177861,
    which deleted many V8_DEPRECATE_SOON methods rather than moving them to
    V8_DEPRECATED first. This puts them back and marks them V8_DEPRECATED.
    
    Note V8_DEPRECATED that were deleted in the same CL stay deleted.
    
    NOTRY=true
    NOPRESUBMIT=true
    NOTREECHECKS=true
    
    Bug: v8:7786, v8:8240
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: I00330036d957f98dab403465b25e30d8382aac22
    Reviewed-on: https://chromium-review.googlesource.com/1251422
    Commit-Queue: Dan Elphick <[email protected]>
    Reviewed-by: Yang Guo <[email protected]>
    Reviewed-by: Michael Hablich <[email protected]>
    Cr-Commit-Position: refs/branch-heads/7.0@{#49}
    Cr-Branched-From: 6e2adae-refs/heads/7.0.276@{#1}
    Cr-Branched-From: bc08a86-refs/heads/master@{#55424}
    danelphick authored and Commit Bot committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    9136dd8 View commit details
    Browse the repository at this point in the history
  2. Version 7.0.276.24

    TBR=v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com
    
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: Ib7c210d6085625c4d7fd2de67729fa9f6e906094
    Reviewed-on: https://chromium-review.googlesource.com/1256702
    Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
    Cr-Commit-Position: refs/branch-heads/7.0@{#50}
    Cr-Branched-From: 6e2adae-refs/heads/7.0.276@{#1}
    Cr-Branched-From: bc08a86-refs/heads/master@{#55424}
    V8 Autoroll committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    5bdc84e View commit details
    Browse the repository at this point in the history
Loading