Skip to content

Commit e0dc7e8

Browse files
ManishearthV8 LUCI CQ
authored andcommitted
[temporal] Pull in temporal_capi 0.1.1
This updates to temporal_capi 0.1.1, which pulls in the last piece of temporal_rs. With this, we pass almost all test262 tests: the remaining failures are: - Duration precision/rounding edge cases that may need more spec clarification. - Tests for out-of-normal-range Chinese/Korean behavior. These tests are just incorrect. - Test for the `islamic` code. This is being fixed in boa-dev/temporal#609 and will be patched shortly. We might want to let this bake with the fuzzer for a bit first. Bug: 401065166 Change-Id: I7a5ca632078f002fb7c1982b9f7b8a806a6a6964 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7094981 Commit-Queue: Manish Goregaokar <[email protected]> Reviewed-by: Leszek Swirski <[email protected]> Cr-Commit-Position: refs/heads/main@{#103403}
1 parent 084d365 commit e0dc7e8

File tree

3 files changed

+6
-52
lines changed

3 files changed

+6
-52
lines changed

DEPS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,7 @@ deps = {
510510
'tools/win':
511511
Var('chromium_url') + '/chromium/src/tools/win' + '@' + '24494b071e019a2baea4355d9870ffc5fc0bbafe',
512512
'third_party/rust':
513-
Var('chromium_url') + '/chromium/src/third_party/rust' + '@' + '9410a262967bceef8d2c00ecdb349a4eba2f9b4c',
513+
Var('chromium_url') + '/chromium/src/third_party/rust' + '@' + '00d55a4041b3595c4852555774189a4a46779658',
514514
'third_party/rust-toolchain': {
515515
'dep_type': 'gcs',
516516
'bucket': 'chromium-browser-clang',

src/objects/js-date-time-format.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -946,10 +946,6 @@ bool CalendarEquals(temporal_rs::AnyCalendarKind kind,
946946
case HijriTabularTypeIIFriday:
947947
return other_kind == "islamic-civil" || other_kind == "islamicc" ||
948948
other_kind == "islamic";
949-
#ifdef TEMPORAL_CAPI_VERSION_0_1
950-
case HijriSimulatedMecca:
951-
return other_kind == "islamic-rgsa" || other_kind == "islamic";
952-
#endif
953949
case HijriTabularTypeIIThursday:
954950
return other_kind == "islamic-tbla" || other_kind == "islamic";
955951
case HijriUmmAlQura:

test/test262/test262.status

Lines changed: 5 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -271,61 +271,19 @@
271271
'built-ins/Temporal/Duration/prototype/total/precision-exact-mathematical-values-6': [FAIL],
272272
'built-ins/Temporal/Duration/prototype/total/precision-exact-mathematical-values-7': [FAIL],
273273

274-
# Remapping out-of-range eras (https://github.com/boa-dev/temporal/issues/448)
275-
'intl402/Temporal/PlainDate/from/remapping-era': [FAIL],
276-
'intl402/Temporal/PlainYearMonth/from/remapping-era': [FAIL],
277-
278-
# We need a way to regulate non-ISO on construction (https://github.com/unicode-org/icu4x/issues/6790)
279-
'staging/Intl402/Temporal/old/indian-calendar': [FAIL],
280-
'staging/Intl402/Temporal/old/non-iso-calendars-japanese': [FAIL],
281-
'intl402/Temporal/PlainMonthDay/from/reference-year-1972': [FAIL],
282-
283-
# We need to be able to construct from ordinal months (https://github.com/unicode-org/icu4x/issues/6790)
284-
'staging/Intl402/Temporal/old/hebrew-leap-months': [FAIL],
285-
286-
# PlainMonthDay needs to support Chinese/Dangi (https://github.com/boa-dev/temporal/issues/450)
287-
'intl402/Temporal/PlainMonthDay/from/constrain-to-leap-day': [FAIL],
288-
'intl402/Temporal/PlainYearMonth/from/reference-day-chinese': [FAIL],
289-
290-
# Chinese/Dangi need to use related_iso as their arithmetical year (https://github.com/unicode-org/icu4x/pull/6800)
291-
'intl402/Temporal/PlainDate/prototype/until/until-across-lunisolar-leap-months': [FAIL],
292-
'staging/Intl402/Temporal/old/non-iso-calendars-chinese': [FAIL],
293-
'staging/Intl402/Temporal/old/non-iso-calendars-dangi': [FAIL],
294-
295-
# Non-ISO datetime arithmetic (https://github.com/unicode-org/icu4x/issues/1174)
296-
'staging/Intl402/Temporal/old/non-iso-calendars-buddhist': [FAIL],
297-
'staging/Intl402/Temporal/old/non-iso-calendars-coptic': [FAIL],
298-
'staging/Intl402/Temporal/old/non-iso-calendars-ethioaa': [FAIL],
299-
'staging/Intl402/Temporal/old/non-iso-calendars-ethiopic': [FAIL],
300-
'staging/Intl402/Temporal/old/non-iso-calendars-gregory': [FAIL],
301-
'staging/Intl402/Temporal/old/non-iso-calendars-hebrew': [FAIL],
302-
'staging/Intl402/Temporal/old/non-iso-calendars-indian': [FAIL],
303-
'staging/Intl402/Temporal/old/non-iso-calendars-islamicc': [FAIL],
304-
'staging/Intl402/Temporal/old/non-iso-calendars-islamic-civil': [FAIL],
305-
'staging/Intl402/Temporal/old/non-iso-calendars-islamic-tbla': [FAIL],
306-
'staging/Intl402/Temporal/old/non-iso-calendars-islamic-umalqura': [FAIL],
307-
'staging/Intl402/Temporal/old/non-iso-calendars-persian': [FAIL],
308-
'staging/Intl402/Temporal/old/non-iso-calendars-roc': [FAIL],
309-
'staging/Intl402/Temporal/old/islamic-calendars-islamic-civil': [FAIL],
310-
'staging/Intl402/Temporal/old/islamic-calendars-islamic-tbla': [FAIL],
311-
'staging/Intl402/Temporal/old/islamic-calendars-islamic-umalqura': [FAIL],
312-
'staging/Intl402/Temporal/old/persian-calendar': [FAIL],
313-
'intl402/Temporal/PlainYearMonth/from/reference-day-hebrew': [FAIL],
314-
'intl402/Temporal/PlainMonthDay/from/calendar-not-supporting-eras': [FAIL],
315-
'intl402/Temporal/PlainYearMonth/prototype/add/options-undefined': [FAIL],
316-
'intl402/Temporal/PlainYearMonth/prototype/subtract/options-undefined': [FAIL],
317-
'staging/Intl402/Temporal/old/addition-across-lunisolar-leap-months-chinese': [FAIL],
318-
'staging/Intl402/Temporal/old/addition-across-lunisolar-leap-months-hebrew': [FAIL],
319-
320274
# No issue filed
321275

322276
# Temporal should error on the ambiguous `islamic` calendar
323277
'staging/Intl402/Temporal/old/islamic-calendars-islamic': [FAIL],
324-
'staging/Intl402/Temporal/old/islamic-calendars-islamic-rgsa': [FAIL],
325278

326279
# ICU4C and ICU4X disagree on canonical timezones
327280
'intl402/Temporal/ZonedDateTime/prototype/equals/canonical-not-equal': [FAIL],
328281

282+
# Test errors for out-of-ground-truth-range calendars (expected, test is broken)
283+
'staging/Intl402/Temporal/old/non-iso-calendars-chinese': [FAIL],
284+
'staging/Intl402/Temporal/old/non-iso-calendars-dangi': [FAIL],
285+
'intl402/Temporal/PlainYearMonth/from/reference-day-chinese': [FAIL],
286+
329287
# End Temporal test expectations
330288

331289

0 commit comments

Comments
 (0)