Add Steam cloud saves browser shortcut#840
Conversation
📝 WalkthroughWalkthroughThe pull request introduces a new "Browse Online Saves" menu option to the game library interface. The change spans three files: defining the new enum constant, implementing the option in the Steam app screen with an Intent to open the store's remote storage page, and configuring its icon and category placement in the options panel. Changes
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 3 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/src/main/java/app/gamenative/ui/enums/AppOptionMenuType.kt">
<violation number="1" location="app/src/main/java/app/gamenative/ui/enums/AppOptionMenuType.kt:22">
P3: New user-visible menu label is hardcoded instead of using a string resource, which bypasses localization and the project’s no-hardcoded-UI-strings guidance.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@app/src/main/java/app/gamenative/ui/screen/library/appscreen/SteamAppScreen.kt`:
- Around line 763-769: The onClick handler in SteamAppScreen.kt launches a
browser Intent directly (Uri.parse("https://store.steampowered.com/...$gameId"))
which can throw ActivityNotFoundException or a ContextException when the
provided Context is not an Activity; update the onClick to defensively resolve
and launch the intent: create the ACTION_VIEW intent, call
intent.resolveActivity(context.packageManager) (or use
context.packageManager.queryIntentActivities) to ensure an activity can handle
it, and if the context is not an Activity add Intent.FLAG_ACTIVITY_NEW_TASK
before calling context.startActivity; also wrap startActivity in a try/catch for
ActivityNotFoundException to log/safely handle failures; apply the same
defensive changes to the identical pattern in BaseAppScreen.kt.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 524a150e-47ce-4e8e-92d9-467a0127d5b0
📒 Files selected for processing (3)
app/src/main/java/app/gamenative/ui/enums/AppOptionMenuType.ktapp/src/main/java/app/gamenative/ui/screen/library/appscreen/SteamAppScreen.ktapp/src/main/java/app/gamenative/ui/screen/library/components/GameOptionsPanel.kt
|
When i try open via this button i need again auth my steam account for opened site. That's normal behaviour? We can't reuse auth from gamenative caches? |
3 participants
simple convenience feature, for steam games, open steam cloud management page in your default browser
Summary by cubic
Adds a “Browse online saves” shortcut for Steam games to open the game’s Steam Cloud page in your default browser. The option is available even if the game isn’t installed.
Written for commit c260193. Summary will update on new commits.
Summary by CodeRabbit