Skip to content

Added package to annotation warnings. #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PhilippSalvisberg merged 1 commit into from
Jul 2, 2019
Merged

Added package to annotation warnings. #964

PhilippSalvisberg merged 1 commit into from
Jul 2, 2019

Conversation

@jgebal
Copy link
Member

@jgebal jgebal commented Jul 2, 2019

Resolves #960

@jgebal jgebal added this to the v3.1.8 milestone Jul 2, 2019
@jgebal jgebal requested a review from PhilippSalvisberg July 2, 2019 01:13
PhilippSalvisberg
PhilippSalvisberg approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@PhilippSalvisberg PhilippSalvisberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@PhilippSalvisberg PhilippSalvisberg merged commit fccc966 into develop Jul 2, 2019
@jgebal jgebal deleted the feature/add_package_keyword_to_warnings branch July 3, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PhilippSalvisberg PhilippSalvisberg PhilippSalvisberg approved these changes

@lwasylow lwasylow lwasylow approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

v3.1.8

Development

Successfully merging this pull request may close these issues.

Code reference with object type

4 participants

@jgebal @PhilippSalvisberg @lwasylow