fix(file): don't output binary file content#7874
Merged
olblak merged 8 commits intoupdatecli:mainfrom Mar 22, 2026
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add isBinaryContent() to detect binary files by null bytes
Add truncateBinaryContent() to show friendly message
Update target.go to check content before logging diffs
Update condition.go to check content before logging diffs
Add comprehensive unit tests for binary detection
When file resources process binary files (e.g., .cnb containers, executables), the output is now truncated to '[binary content, X bytes]' instead of dumping raw binary data to the console.
Fixes #3636
Fix #XXX
Test
To test this pull request, you can run the following commands:
Additional Information
Checklist
Tradeoff
Potential improvement