fix(googleicons): remove wrong and unused request#203
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes an unused fetch request to the Google icons endpoint that was returning a 404 and interfering with CSS parsing. Key changes include:
- Removal of the asynchronous fetch call in src/providers/googleicons.ts.
- An update to the test in test/providers/googleicons.test.ts to reflect the supported woff2 format.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/providers/googleicons.ts | Removed the unused Google icons fetch request to avoid 404 errors |
| test/providers/googleicons.test.ts | Updated test data to include a woff2 font source in the expected format |
Comments suppressed due to low confidence (2)
src/providers/googleicons.ts:41
- The removal of the unused fetch call for Google icons is appropriate given that it returns a 404, but please confirm that no component depends on any side effects from this call.
if (family.includes('Icons')) { ... }
test/providers/googleicons.test.ts:355
- The addition of the woff2 format test case is beneficial; ensure that the test case data fully aligns with the expected behavior of the provider.
{
danielroe
approved these changes
Jun 9, 2025
Collaborator
Author
|
@danielroe The checks are passing, I'm merging it now. Noticed a minor system issue on adobe's status page, might have caused the timeout 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request to
https://fonts.googleapis.com/icon/css2is not used and returns 404. The 404 html also interferes with the CSS parser that it cannot correctly parse the woff2 file.