Skip to content

fix(cjs): include d.ts cjs transformation when cjs package#526

Open
userquin wants to merge 1 commit intounjs:mainfrom
userquin:fix-include-cjs-d_ts-only-in-cjs-package
Open

fix(cjs): include d.ts cjs transformation when cjs package#526
userquin wants to merge 1 commit intounjs:mainfrom
userquin:fix-include-cjs-d_ts-only-in-cjs-package

Conversation

@userquin
Copy link
Copy Markdown
Contributor

@userquin userquin commented Apr 3, 2025

Right now, we're generating wrong CJS d.ts files based on declaration option and we shoud check the package is NOT ESM ; we only need to transform d.ts files when type !== module.

/cc @pio

Check unjs/destr below and this gh repro: https://github.com/userquin/destr-consola-test

unjs/destr

image
unjs/destr

image
unjs/destr at arethetypeswrong

image
unjs/destr/package.json

  "exports": {
    ".": {
      "import": "./dist/index.mjs",
      "require": "./dist/index.cjs"
    }
  },
  "main": "./dist/index.cjs",
  "module": "./dist/index.mjs",
  "types": "./dist/index.d.ts",

unjs/destr exports

@pi0 pi0 requested a review from danielroe April 3, 2025 22:30
@userquin
Copy link
Copy Markdown
Contributor Author

userquin commented Apr 3, 2025 •
edited
Loading

Some problems when using require, looks like we need the namespace creation. I'm going to check esm, but it should work (creating esm branch in the gh repo).

Arrrgg, it is working, I need to run tsc && node ./src/index.cjs:

node ./src/index.cjs
{ foo: 'bar' }

Works with both, node and node16 module resolution:

    "module": "Node16",
    "moduleResolution": "node16",

and

    "module": "CommonJS",
    "moduleResolution": "node",

NOTE: added build, build:node16 and typecheck:node16 script in the gh repro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe Awaiting requested review from danielroe

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@userquin @pi0