fix: deduplicate warnedMessages

danielroe · danielroe · commit 30fd696e716f · 2026-03-09T17:42:01.000Z
diff --git a/src/index.ts b/src/index.ts
@@ -138,6 +138,7 @@ interface PendingViolation {
   suggestions?: string[]
   options: ImpoundMatcherOptions
   errorFn: (msg: string) => void
+  warnedMessages: Set<string> | undefined
 }
 
 /** Convert a byte offset in source code to a 1-indexed line and 0-indexed column. */
@@ -472,6 +473,7 @@ export const ImpoundPlugin = createUnplugin<ImpoundOptions>((globalOptions) => {
                 suggestions,
                 options,
                 errorFn,
+                warnedMessages,
               }
 
               if (moduleGraph.has(importer)) {
@@ -584,8 +586,7 @@ export const ImpoundPlugin = createUnplugin<ImpoundOptions>((globalOptions) => {
         if (pending) {
           pendingViolations.delete(key)
           for (const violation of pending) {
-            const warnedMessages = violation.options.warn !== 'always' ? new Set<string>() : undefined
-            enrichAndReport(violation, moduleGraph, resolvedImports, entries, maxTraceDepth, globalOptions.cwd, warnedMessages)
+            enrichAndReport(violation, moduleGraph, resolvedImports, entries, maxTraceDepth, globalOptions.cwd, violation.warnedMessages)
           }
         }
       }
diff --git a/test/index.test.ts b/test/index.test.ts
@@ -994,6 +994,37 @@ describe('trace mode (deferred violations)', () => {
 
     errorSpy.mockRestore()
   })
+
+  it('deduplicates deferred violations using shared warnedMessages set from matcher', async () => {
+    const errorSpy = vi.spyOn(console, 'error').mockImplementation(() => {})
+
+    // Use two patterns that produce the same message for the same import
+    const plugins = ImpoundPlugin.rollup({ trace: true, patterns: [['secret', 'Not allowed']], error: false })
+    const pluginArray = Array.isArray(plugins) ? plugins : [plugins]
+    const impoundPlugin = pluginArray.find(p => p.name === 'impound')!
+    const tracePlugin = pluginArray.find(p => p.name === 'impound:trace')!
+
+    const context = { error: () => {} }
+
+    // First: defer a violation, then flush via transform
+    await (impoundPlugin as any).resolveId.call(context, 'secret', 'a.js')
+    await (tracePlugin as any).transform('import secret from "secret"', 'a.js')
+    expect(errorSpy).toHaveBeenCalledTimes(1)
+
+    // Second: same import from a different file triggers immediate path (a.js already in graph).
+    // The warnedMessages set is shared with the matcher, so the *immediate* violation from b.js
+    // is a different message (different importer) and should log.
+    await (tracePlugin as any).transform('import secret from "secret"', 'b.js')
+    await (impoundPlugin as any).resolveId.call(context, 'secret', 'b.js')
+    expect(errorSpy).toHaveBeenCalledTimes(2)
+
+    // Third: re-resolve 'secret' from a.js &mdash; immediate path, same message as first.
+    // Should be deduped because the deferred flush used the matcher's warnedMessages set.
+    await (impoundPlugin as any).resolveId.call(context, 'secret', 'a.js')
+    expect(errorSpy).toHaveBeenCalledTimes(2) // still 2, deduped
+
+    errorSpy.mockRestore()
+  })
 })
 
 async function buildWithTrace(files: Record<string, string>, libs: string[], opts: ImpoundOptions, extraPlugins: any[] = []) {

Original file line number	Diff line number	Diff line change
`@@ -138,6 +138,7 @@ interface PendingViolation {`
`138`	`138`	`suggestions?: string[]`
`139`	`139`	`options: ImpoundMatcherOptions`
`140`	`140`	`errorFn: (msg: string) => void`
	`141`	`+ warnedMessages: Set<string> \| undefined`
`141`	`142`	`}`
`142`	`143`
`143`	`144`	`/** Convert a byte offset in source code to a 1-indexed line and 0-indexed column. */`
`@@ -472,6 +473,7 @@ export const ImpoundPlugin = createUnplugin<ImpoundOptions>((globalOptions) => {`
`472`	`473`	`suggestions,`
`473`	`474`	`options,`
`474`	`475`	`errorFn,`
	`476`	`+ warnedMessages,`
`475`	`477`	`}`
`476`	`478`
`477`	`479`	`if (moduleGraph.has(importer)) {`
`@@ -584,8 +586,7 @@ export const ImpoundPlugin = createUnplugin<ImpoundOptions>((globalOptions) => {`
`584`	`586`	`if (pending) {`
`585`	`587`	`pendingViolations.delete(key)`
`586`	`588`	`for (const violation of pending) {`
`587`		`- const warnedMessages = violation.options.warn !== 'always' ? new Set<string>() : undefined`
`588`		`- enrichAndReport(violation, moduleGraph, resolvedImports, entries, maxTraceDepth, globalOptions.cwd, warnedMessages)`
	`589`	`+ enrichAndReport(violation, moduleGraph, resolvedImports, entries, maxTraceDepth, globalOptions.cwd, violation.warnedMessages)`
`589`	`590`	`}`
`590`	`591`	`}`
`591`	`592`	`}`