Merged
Conversation
IWANABETHATGUY
commented
Aug 3, 2024
| } else { | ||
| consola.error(error, "\n"); | ||
| } | ||
| consola.error(error.message); |
Contributor
Author
There was a problem hiding this comment.
There are only two conditions, is cli error or not, so we can make sure there must be something printed already, if the erroris undefined theerror.message` should be empty or raise a runtime error. So just remove it to avoid printing duplicated error.
pi0
approved these changes
Mar 8, 2025
Member
pi0
left a comment
pi0
left a comment
There was a problem hiding this comment.
Thanks for PR. The idea was intentional to show brief message only in the end. But I guess is better to show once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed #166
for https://github.com/IWANABETHATGUY/citty-reproduce/tree/master
Before
After