plat/kvm: Remove stale ELF64_TO_32 in favor of multiboot config - #1900
Open
mogasergiu wants to merge 1 commit into
Open
mogasergiu wants to merge 1 commit into
mogasergiu wants to merge 1 commit into
Conversation
This `ELF64_TO_32` was introduced back when the python script that creates ELF32-equivalent for Multiboot booting was added. It has been since renamed to `multiboot.py` because it's the only boot protocol that has this requirement and this `ELF64_TO_32` should have been deleted along with it and replaced with the multiboot config instead. Do so now. Signed-off-by: Sergiu Moga <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
ELF64_TO_32was introduced back when the python script that creates ELF32-equivalent for Multiboot booting was added. It has been since renamed tomultiboot.pybecause it's the only boot protocol that has this requirement and thisELF64_TO_32should have been deleted along with it and replaced with the multiboot config instead. Do so now.Description of Changes
Related Work
N/A
PR Checklist
checkpatch.ukon your commit series before opening this PR;