refactor(consumer): lift queue consumer framework to be shared across submitqueue + stovepipe#228
Open
mnoah1 wants to merge 1 commit into
Open
refactor(consumer): lift queue consumer framework to be shared across submitqueue + stovepipe#228mnoah1 wants to merge 1 commit into
mnoah1 wants to merge 1 commit into
Conversation
mnoah1
changed the title
…key packages Move the shared queue consumer framework to top-level core/consumer so both SubmitQueue and Stovepipe can reuse it. Pipeline stage constants now live in per-domain submitqueue/core/topickey and stovepipe/core/topickey packages.
mnoah1
force-pushed
the
mnoah1/lift-core-consumer
branch
from
30db103 to
2a53a64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the shared queue consumer framework to top-level core/consumer so both SubmitQueue and Stovepipe can reuse it. Pipeline stage constants now live in per-domain submitqueue/core/topickey and stovepipe/core/topickey packages.
Why?
Queue management will follow a similar framework for stovepipe, this is infra that can be shared.
What?
Move core/consumer package up a level and update all reference and docs. Topic keys move to their own package since they are domain specific
Test Plan