tools/testramfs/cinema: fix player embedding#3484
Merged
orangecms merged 1 commit intou-root:mainfrom Jan 13, 2026
Merged
Conversation
Member
orangecms
commented
Jan 12, 2026
orangecms
commented
- use latest asciinema player, load in see https://www.jsdelivr.com/package/npm/asciinema-player
- use htmlpreview URL for cast file
- use latest asciinema player, load in <head> see <https://www.jsdelivr.com/package/npm/asciinema-player> - use htmlpreview URL for cast file Signed-off-by: Daniel Maslowski <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3484 +/- ##
==========================================
- Coverage 61.91% 61.86% -0.05%
==========================================
Files 638 638
Lines 43150 43150
==========================================
- Hits 26717 26696 -21
- Misses 16433 16454 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
rminnich
approved these changes
Jan 13, 2026
Member
rminnich
left a comment
rminnich
left a comment
There was a problem hiding this comment.
Thanks daniel! I knew if anyone fixed this it would be you :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.