Conversation
rminnich
requested review from
a team,
10000TB,
abarisani,
andrewsun2898,
binjip978,
brho and
Copilot
There was a problem hiding this comment.
Pull request overview
This pull request adds timing instrumentation to display how long the u-root build takes in the testramfs tool. The changes include importing the time package and wrapping the build execution with timing code that outputs the duration in seconds with an asterisk border decoration.
Key Changes:
- Added timing measurement for u-root builds
- Outputs build duration to stderr with decorative borders
- Includes a large cinema recording file (5850 lines) showing test output
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/testramfs/testramfs.go | Added time import and build duration tracking with formatted output |
| tools/testramfs/cinema/linux_arm64 | Added cinema recording file showing terminal output of test execution |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3482 +/- ##
=======================================
Coverage 62.01% 62.01%
=======================================
Files 638 638
Lines 43150 43150
=======================================
+ Hits 26758 26759 +1
+ Misses 16392 16391 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
gotta love that nsec resolution! (will +2 after that one nit about time.Since()) |
It will onw print this for the u-root build: ************************************************ u-root build took 7.047367875 seconds ************************************************ Useful for showing people. Signed-off-by: Ronald G. Minnich <[email protected]>
THe plan is to make these visible on the web page Signed-off-by: Ronald G. Minnich <[email protected]>
rminnich
force-pushed
the
advertisement
branch
from
23279b2 to
eeb14e0
Compare
|
If you mean the asciinema, I figure they are not that big, and I want them showing when people go to GitHub.com/u-root/u-root, to give som idea of how it works and how fast it is. I have a feeling people still won't appreciate how fast this build works, but we have to try. |
thinking of putting them on the README.md page? |
No description provided.