Skip to content

Revert "menu cleanups" to unblock Github CI#3441

Merged
AjanZhong merged 2 commits intomainfrom
revert-3427-main
Aug 23, 2025
Merged

Revert "menu cleanups" to unblock Github CI#3441
AjanZhong merged 2 commits intomainfrom
revert-3427-main

Conversation

@AjanZhong
Copy link
Copy Markdown
Contributor

@AjanZhong AjanZhong commented Aug 22, 2025

Reverts #3427

Trace log cannot be prompted via same terminal if no entry is selected by user in boot menu after time out. Revert this PR to unblock Github CI integration/generic-tests TestPxeboot4

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.33%. Comparing base (c9a322d) to head (7e8c927).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3441      +/-   ##
==========================================
+ Coverage   55.18%   59.33%   +4.15%     
==========================================
  Files         634      637       +3     
  Lines       54101    54104       +3     
==========================================
+ Hits        29855    32104    +2249     
+ Misses      24246    22000    -2246     
Flag Coverage Δ
.-amd64 88.88% <ø> (ø)
cmds/...-amd64 49.11% <ø> (ø)
integration/generic-tests/...-amd64 30.14% <76.92%> (?)
integration/generic-tests/...-arm 31.98% <76.92%> (?)
integration/generic-tests/...-arm64 29.30% <76.92%> (?)
integration/gotests/...-amd64 59.85% <0.00%> (+<0.01%) ⬆️
integration/gotests/...-arm 60.48% <0.00%> (+<0.01%) ⬆️
integration/gotests/...-arm64 60.64% <0.00%> (+<0.01%) ⬆️
pkg/...-amd64 57.64% <76.92%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
everything 64.23% <76.92%> (+4.86%) ⬆️
cmds/exp 31.08% <ø> (+0.35%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AjanZhong AjanZhong changed the title Revert "menu cleanups" Revert "menu cleanups" to unblock Github CI Aug 22, 2025
@AjanZhong AjanZhong enabled auto-merge (rebase) August 23, 2025 02:02
@rminnich
Copy link
Copy Markdown
Member

needs a signed-off-by

This reverts commit c9a322d.

Signed-off-by: Ajan Zhong <[email protected]>
This reverts commit c3217ac.

Signed-off-by: Ajan Zhong <[email protected]>
@AjanZhong
Copy link
Copy Markdown
Contributor Author

@jelischer This PR will revert your changes, you can use following command in integration/generic-tests/ folder.
VMTEST_ARCH=arm runvmtest -- go test -v -run TestPxeboot4
Thanks.

@AjanZhong
Copy link
Copy Markdown
Contributor Author

needs a signed-off-by

Done

@AjanZhong AjanZhong merged commit 2856670 into main Aug 23, 2025
31 checks passed
@AjanZhong AjanZhong deleted the revert-3427-main branch August 23, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants