Skip to content

dhclient: actually time out on DAD & routing#2914

Merged
hugelgupf merged 2 commits intou-root:mainfrom
hugelgupf:dad-timeout
Feb 13, 2024
Merged

dhclient: actually time out on DAD & routing#2914
hugelgupf merged 2 commits intou-root:mainfrom
hugelgupf:dad-timeout

Conversation

@hugelgupf
Copy link
Copy Markdown
Member

@hugelgupf hugelgupf commented Feb 13, 2024

On the list to be tested...

@hugelgupf hugelgupf requested a review from a team February 13, 2024 05:40
@hugelgupf hugelgupf enabled auto-merge (rebase) February 13, 2024 05:40
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (097afe0) 78.22% compared to head (28f72a0) 78.22%.

❗ Current head 28f72a0 differs from pull request most recent head 3f71e5e. Consider uploading reports for the commit 3f71e5e to get more accurate results

Files Patch % Lines
pkg/dhclient/dhclient.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2914   +/-   ##
=======================================
  Coverage   78.22%   78.22%           
=======================================
  Files         421      421           
  Lines       42891    42893    +2     
=======================================
+ Hits        33550    33552    +2     
  Misses       9341     9341           
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.40% <ø> (+0.01%) ⬆️
integration/generic-tests/...-amd64 20.51% <0.00%> (-0.01%) ⬇️
integration/generic-tests/...-arm 11.70% <0.00%> (-0.01%) ⬇️
integration/generic-tests/...-arm64 23.98% <0.00%> (-0.01%) ⬇️
integration/gotests/...-amd64 74.69% <0.00%> (-0.01%) ⬇️
integration/gotests/...-arm 76.04% <0.00%> (-0.01%) ⬇️
integration/gotests/...-arm64 75.93% <0.00%> (-0.01%) ⬇️
pkg/...-amd64 76.65% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@jelischer jelischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. actually fixes the issue on my test machine.

@hugelgupf hugelgupf disabled auto-merge February 13, 2024 16:44
@hugelgupf hugelgupf merged commit 4420d1b into u-root:main Feb 13, 2024
@hugelgupf hugelgupf deleted the dad-timeout branch February 13, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants