Skip to content

kexec: switch segments to use []byte#2883

Merged
hugelgupf merged 1 commit intou-root:mainfrom
hugelgupf:segment
Feb 1, 2024
Merged

kexec: switch segments to use []byte#2883
hugelgupf merged 1 commit intou-root:mainfrom
hugelgupf:segment

Conversation

@hugelgupf
Copy link
Copy Markdown
Member

This makes segment management much easier. It removes the "pool" hack we were using to keep pieces of memory alive. Convert them to kexec format only when actual kexec syscall is called.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (f1f7f83) 77.30% compared to head (41710d2) 77.28%.

Files Patch % Lines
pkg/boot/kexec/kexec_load_linux.go 88.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2883      +/-   ##
==========================================
- Coverage   77.30%   77.28%   -0.02%     
==========================================
  Files         429      429              
  Lines       43088    43088              
==========================================
- Hits        33310    33302       -8     
- Misses       9778     9786       +8     
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.40% <ø> (ø)
integration/generic-tests/...-amd64 18.40% <65.85%> (+0.18%) ⬆️
integration/generic-tests/...-arm 0.00% <ø> (ø)
integration/generic-tests/...-arm64 22.13% <65.85%> (+0.33%) ⬆️
integration/gotests/...-amd64 74.07% <39.02%> (-0.08%) ⬇️
integration/gotests/...-arm 75.37% <ø> (-0.08%) ⬇️
integration/gotests/...-arm64 75.02% <39.02%> (-0.08%) ⬇️
pkg/...-amd64 76.05% <39.02%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This makes segment management much easier. It removes the "pool" hack we
were using to keep pieces of memory alive. Convert them to kexec format
only when actual kexec syscall is called.

Signed-off-by: Chris Koch <[email protected]>
@hugelgupf hugelgupf merged commit 258f0c7 into u-root:main Feb 1, 2024
@hugelgupf hugelgupf deleted the segment branch February 1, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants