kexec: memory map improvements (incl dumpmemmap command)#2864
Merged
hugelgupf merged 12 commits intou-root:mainfrom Jan 29, 2024
Merged
kexec: memory map improvements (incl dumpmemmap command)#2864hugelgupf merged 12 commits intou-root:mainfrom
hugelgupf merged 12 commits intou-root:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2864 +/- ##
==========================================
- Coverage 77.45% 77.32% -0.14%
==========================================
Files 427 428 +1
Lines 42954 43060 +106
==========================================
+ Hits 33272 33296 +24
- Misses 9682 9764 +82
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hugelgupf
force-pushed
the
iomem
branch
2 times, most recently
from
06efc02 to
2dea5f5
Compare
hugelgupf
changed the title
| } | ||
| m.Insert(TypedRange{ | ||
| // end is inclusive. | ||
| Range: RangeFromInterval(uintptr(start), uintptr(end+1)), |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
| return nil | ||
| } | ||
| // end is inclusive. | ||
| r := RangeFromInterval(uintptr(start), uintptr(end+1)) |
Check failure
Code scanning / CodeQL
Incorrect conversion between integer types
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
hugelgupf
force-pushed
the
iomem
branch
3 times, most recently
from
71abebd to
2dd188d
Compare
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
hugelgupf
force-pushed
the
iomem
branch
2 times, most recently
from
c07c3b0 to
621aee0
Compare
Clarifies what this type is used for. Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Closed
rminnich
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a large PR, but the individual commits should be easy to review if going in order.
ParseMemoryMaptoMemoryMapFromEFIto clarify origin of data (and that it only works on EFI systems)This is working toward a place where every kexec parser uses a valid memory map for the host system. Just improving the primitives and their readability / usability here.