cmds/core/ping: fix counter bug#2724
Merged
rminnich merged 4 commits intou-root:mainfrom Jul 27, 2023
Merged
Conversation
binjip978
force-pushed
the
fix-ping-count
branch
from
7820343 to
6ce6ac5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2724 +/- ##
==========================================
- Coverage 75.57% 75.40% -0.17%
==========================================
Files 414 414
Lines 42257 42257
==========================================
- Hits 31934 31865 -69
- Misses 10323 10392 +69
☔ View full report in Codecov by Sentry. |
Member
|
why not just have the default value of c be math.MaxUint64 instead of 0? That would be a very minimal change which would have the same effect. |
rminnich
added
Awaiting author
rminnich
previously approved these changes
Jul 23, 2023
ping can run forever if c equal to zero and run correct number of iteration if c is none zero Signed-off-by: Siarhiej Siemianczuk <[email protected]>
Signed-off-by: Siarhiej Siemianczuk <[email protected]>
binjip978
force-pushed
the
fix-ping-count
branch
from
5d01e30 to
cbf9bac
Compare
binjip978
added
Awaiting reviewer
rminnich
approved these changes
Jul 27, 2023
rminnich
added
automerge
rminnich
approved these changes
Jul 27, 2023
rminnich
approved these changes
Jul 27, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ping can run forever if c equal to zero
and run correct number of iteration if c is none zero