pkg/termios: fix darwin regression from previous commit, add tests#2594
Merged
hugelgupf merged 1 commit intou-root:mainfrom Jan 9, 2023
Merged
pkg/termios: fix darwin regression from previous commit, add tests#2594hugelgupf merged 1 commit intou-root:mainfrom
hugelgupf merged 1 commit intou-root:mainfrom
Conversation
bradfitz
force-pushed
the
bradfitz/fix_darwin
branch
from
2e7db3a to
b2a5bf1
Compare
Contributor
Author
|
/cc @hugelgupf |
|
Small typo in description: addition |
bradfitz
force-pushed
the
bradfitz/fix_darwin
branch
from
b2a5bf1 to
cb1a87e
Compare
Contributor
Author
Whoops, thanks. Fixed. |
bradfitz
force-pushed
the
bradfitz/fix_darwin
branch
from
9710994 to
f536805
Compare
hugelgupf
reviewed
Jan 9, 2023
hugelgupf
previously approved these changes
Jan 9, 2023
hugelgupf
reviewed
Jan 9, 2023
bradfitz
force-pushed
the
bradfitz/fix_darwin
branch
from
f536805 to
fa4eeba
Compare
Codecov ReportBase: 74.83% // Head: 75.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
==========================================
+ Coverage 74.83% 75.00% +0.16%
==========================================
Files 408 408
Lines 41344 41345 +1
==========================================
+ Hits 30940 31009 +69
+ Misses 10404 10336 -68
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I broke darwin support in the just-merged u-root#2593. To atone for my sins, this PR adds some more test coverage (in addition to fixing darwin). Signed-off-by: Brad Fitzpatrick <[email protected]>
bradfitz
force-pushed
the
bradfitz/fix_darwin
branch
from
fa4eeba to
402cff4
Compare
hugelgupf
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I broke darwin support in the just-merged #2593.
To atone for my sins, this PR adds some more test coverage (in addition to fixing darwin).