Support Go package paths & GBB_PATH#2588
Merged
hugelgupf merged 7 commits intou-root:mainfrom Dec 29, 2022
Merged
Conversation
hugelgupf
force-pushed
the
use-new-glob
branch
4 times, most recently
from
f6a86ff to
3f3ada3
Compare
Codecov ReportBase: 73.55% // Head: 73.54% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2588 +/- ##
==========================================
- Coverage 73.55% 73.54% -0.01%
==========================================
Files 407 406 -1
Lines 41293 41209 -84
==========================================
- Hits 30372 30309 -63
+ Misses 10921 10900 -21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rminnich
previously approved these changes
Dec 29, 2022
hugelgupf
force-pushed
the
use-new-glob
branch
from
3f3ada3 to
90f5fff
Compare
hugelgupf
changed the title
hugelgupf
force-pushed
the
use-new-glob
branch
from
eec21bd to
afb74c4
Compare
Signed-off-by: Chris Koch <[email protected]>
Allows resolving of both file system and Go package paths & globs; introduces GBB_PATH support. Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
[skip ci] Signed-off-by: Chris Koch <[email protected]>
Signed-off-by: Chris Koch <[email protected]>
All uses have been replaced. Signed-off-by: Chris Koch <[email protected]>
hugelgupf
force-pushed
the
use-new-glob
branch
from
f93bcef to
60cb1e5
Compare
Member
|
This is delightful to have back. |
rminnich
approved these changes
Dec 29, 2022
rminnich
reviewed
Dec 29, 2022
| You can now use the u-root command to build an initramfs. Here are some | ||
| examples with $UROOT_PATH being the path to where the u-root sources are on the disk | ||
| (explicitly specifiying this is only necessary if not runnig u-root inside the root of the repository): | ||
| You can now use the u-root command to build an initramfs. Here are some examples |
Member
There was a problem hiding this comment.
I am not sure why 'now' is in there, since the initramfs has been in there for-f-ing ever :-) Maybe I did that.
| (explicitly specifiying this is only necessary if not runnig u-root inside the root of the repository): | ||
| You can now use the u-root command to build an initramfs. Here are some examples | ||
| with $UROOT_PATH being the path to where the u-root sources are on the disk | ||
| (explicitly specifiying this is only necessary if not runnig u-root inside the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for Go package paths is back!
Support for Go package path globs is back.
New support for environment variable GBB_PATH.
README should explain everything.