pkg/dt: create idiomatic New(), minimize Linux special-ness#2561
Merged
rminnich merged 1 commit intou-root:mainfrom Nov 15, 2022
Merged
pkg/dt: create idiomatic New(), minimize Linux special-ness#2561rminnich merged 1 commit intou-root:mainfrom
rminnich merged 1 commit intou-root:mainfrom
Conversation
The New takes a variadic of FDTReader functions. The Linux code now supplies 2 kinds: one for io.ReaderAt and another for filenames. The tests now use these. No more racing with changes to a package-level variable. Signed-off-by: Ronald G. Minnich <[email protected]>
Codecov ReportBase: 73.67% // Head: 73.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2561 +/- ##
==========================================
+ Coverage 73.67% 73.69% +0.01%
==========================================
Files 406 406
Lines 41282 41299 +17
==========================================
+ Hits 30416 30434 +18
+ Misses 10866 10865 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
abarisani
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The New takes a variadic of FDTReader functions.
The Linux code now supplies 2 kinds: one for
io.ReaderAt and another for filenames.
The tests now use these. No more racing with changes to a package-level variable.
Signed-off-by: Ronald G. Minnich [email protected]