Skip to content

Commit 6fe6a76

Browse files
julien-deramondjulien-deramond
committed
This commit is not a fix! Just to find the issues!
1 parent 15129e8 commit 6fe6a76

File tree

14 files changed

+56
-54
lines changed

14 files changed

+56
-54
lines changed

‎js/tests/visual/modal.html‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
<div class="container mt-3">
3939
<h1>Modal <small>Bootstrap Visual Test</small></h1>
4040

41-
<div class="modal fade" id="myModal" tabindex="-1" aria-labelledby="myModalLabel" aria-hidden="true">
41+
<div class="modal fade" id="myModal" tabindex="-1" aria-hidden="true">
4242
<div class="modal-dialog">
4343
<div class="modal-content">
4444
<div class="modal-header">
@@ -123,7 +123,7 @@ <h4>Overflowing text to show scroll behavior</h4>
123123
</div>
124124
</div>
125125

126-
<div class="modal fade" id="firefoxModal" tabindex="-1" aria-labelledby="firefoxModalLabel" aria-hidden="true">
126+
<div class="modal fade" id="firefoxModal" tabindex="-1" aria-hidden="true">
127127
<div class="modal-dialog">
128128
<div class="modal-content">
129129
<div class="modal-header">
@@ -147,7 +147,7 @@ <h1 class="modal-title fs-4" id="firefoxModalLabel">Firefox Bug Test</h1>
147147
</div>
148148
</div>
149149

150-
<div class="modal fade" id="slowModal" tabindex="-1" aria-labelledby="slowModalLabel" aria-hidden="true" style="transition-duration: 5s;">
150+
<div class="modal fade" id="slowModal" tabindex="-1" aria-hidden="true" style="transition-duration: 5s;">
151151
<div class="modal-dialog" style="transition-duration: inherit;">
152152
<div class="modal-content">
153153
<div class="modal-header">

‎js/tests/visual/tab.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ <h4>Tabs with fade</h4>
5555

5656
<ul class="nav nav-tabs" role="tablist">
5757
<li class="nav-item" role="presentation">
58-
<button type="button" class="nav-link active" data-bs-toggle="tab" data-bs-target="#home2" role="tab" aria-selected="true">Home</button>
58+
<button type="button" class="nav-link active" data-bs-toggle="tab" data-bs-target="#home2" role="tab" aria-selected="true" aria-controls="home">Home</button>
5959
</li>
6060
<li class="nav-item" role="presentation">
6161
<button type="button" class="nav-link" data-bs-toggle="tab" data-bs-target="#profile2" role="tab">Profile</button>

‎site/src/assets/examples/cheatsheet-rtl/index.astro‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1515,7 +1515,7 @@ import Placeholder from "@shortcodes/Placeholder.astro"
15151515
</section>
15161516
</main>
15171517

1518-
<div class="modal fade" id="exampleModalDefault" tabindex="-1" aria-labelledby="exampleModalLabel" aria-hidden="true">
1518+
<div class="modal fade" id="exampleModalDefault" tabindex="-1" aria-hidden="true">
15191519
<div class="modal-dialog">
15201520
<div class="modal-content">
15211521
<div class="modal-header">
@@ -1532,7 +1532,7 @@ import Placeholder from "@shortcodes/Placeholder.astro"
15321532
</div>
15331533
</div>
15341534
</div>
1535-
<div class="modal fade" id="staticBackdropLive" data-bs-backdrop="static" data-bs-keyboard="false" tabindex="-1" aria-labelledby="staticBackdropLiveLabel" aria-hidden="true">
1535+
<div class="modal fade" id="staticBackdropLive" data-bs-backdrop="static" data-bs-keyboard="false" tabindex="-1" aria-hidden="true">
15361536
<div class="modal-dialog">
15371537
<div class="modal-content">
15381538
<div class="modal-header">
@@ -1549,7 +1549,7 @@ import Placeholder from "@shortcodes/Placeholder.astro"
15491549
</div>
15501550
</div>
15511551
</div>
1552-
<div class="modal fade" id="exampleModalCenteredScrollable" tabindex="-1" aria-labelledby="exampleModalCenteredScrollableTitle" aria-hidden="true">
1552+
<div class="modal fade" id="exampleModalCenteredScrollable" tabindex="-1" aria-hidden="true">
15531553
<div class="modal-dialog modal-dialog-centered modal-dialog-scrollable">
15541554
<div class="modal-content">
15551555
<div class="modal-header">
@@ -1572,7 +1572,7 @@ import Placeholder from "@shortcodes/Placeholder.astro"
15721572
</div>
15731573
</div>
15741574
</div>
1575-
<div class="modal fade" id="exampleModalFullscreen" tabindex="-1" aria-labelledby="exampleModalFullscreenLabel" aria-hidden="true">
1575+
<div class="modal fade" id="exampleModalFullscreen" tabindex="-1" aria-hidden="true">
15761576
<div class="modal-dialog modal-fullscreen">
15771577
<div class="modal-content">
15781578
<div class="modal-header">

‎site/src/assets/examples/cheatsheet/index.astro‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1490,7 +1490,7 @@ export const body_class = 'bg-body-tertiary'
14901490
</section>
14911491
</main>
14921492

1493-
<div class="modal fade" id="exampleModalDefault" tabindex="-1" aria-labelledby="exampleModalLabel" aria-hidden="true">
1493+
<div class="modal fade" id="exampleModalDefault" tabindex="-1" aria-hidden="true">
14941494
<div class="modal-dialog">
14951495
<div class="modal-content">
14961496
<div class="modal-header">
@@ -1507,7 +1507,7 @@ export const body_class = 'bg-body-tertiary'
15071507
</div>
15081508
</div>
15091509
</div>
1510-
<div class="modal fade" id="staticBackdropLive" data-bs-backdrop="static" data-bs-keyboard="false" tabindex="-1" aria-labelledby="staticBackdropLiveLabel" aria-hidden="true">
1510+
<div class="modal fade" id="staticBackdropLive" data-bs-backdrop="static" data-bs-keyboard="false" tabindex="-1" aria-hidden="true">
15111511
<div class="modal-dialog">
15121512
<div class="modal-content">
15131513
<div class="modal-header">
@@ -1524,7 +1524,7 @@ export const body_class = 'bg-body-tertiary'
15241524
</div>
15251525
</div>
15261526
</div>
1527-
<div class="modal fade" id="exampleModalCenteredScrollable" tabindex="-1" aria-labelledby="exampleModalCenteredScrollableTitle" aria-hidden="true">
1527+
<div class="modal fade" id="exampleModalCenteredScrollable" tabindex="-1" aria-hidden="true">
15281528
<div class="modal-dialog modal-dialog-centered modal-dialog-scrollable">
15291529
<div class="modal-content">
15301530
<div class="modal-header">
@@ -1543,7 +1543,7 @@ export const body_class = 'bg-body-tertiary'
15431543
</div>
15441544
</div>
15451545
</div>
1546-
<div class="modal fade" id="exampleModalFullscreen" tabindex="-1" aria-labelledby="exampleModalFullscreenLabel" aria-hidden="true">
1546+
<div class="modal fade" id="exampleModalFullscreen" tabindex="-1" aria-hidden="true">
15471547
<div class="modal-dialog modal-fullscreen">
15481548
<div class="modal-content">
15491549
<div class="modal-header">

‎site/src/assets/examples/dashboard-rtl/index.astro‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export const extra_js = [
8282
<div class="container-fluid">
8383
<div class="row">
8484
<div class="sidebar border border-right col-md-3 col-lg-2 p-0 bg-body-tertiary">
85-
<div class="offcanvas-md offcanvas-end bg-body-tertiary" tabindex="-1" id="sidebarMenu" aria-labelledby="sidebarMenuLabel">
85+
<div class="offcanvas-md offcanvas-end bg-body-tertiary" tabindex="-1" id="sidebarMenu">
8686
<div class="offcanvas-header">
8787
<h5 class="offcanvas-title" id="sidebarMenuLabel">Company name</h5>
8888
<button type="button" class="btn-close" data-bs-dismiss="offcanvas" data-bs-target="#sidebarMenu" aria-label="يغلق"></button>

‎site/src/assets/examples/dashboard/index.astro‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ export const extra_js = [
8181
<div class="container-fluid">
8282
<div class="row">
8383
<div class="sidebar border border-right col-md-3 col-lg-2 p-0 bg-body-tertiary">
84-
<div class="offcanvas-md offcanvas-end bg-body-tertiary" tabindex="-1" id="sidebarMenu" aria-labelledby="sidebarMenuLabel">
84+
<div class="offcanvas-md offcanvas-end bg-body-tertiary" tabindex="-1" id="sidebarMenu">
8585
<div class="offcanvas-header">
8686
<h5 class="offcanvas-title" id="sidebarMenuLabel">Company name</h5>
8787
<button type="button" class="btn-close" data-bs-dismiss="offcanvas" data-bs-target="#sidebarMenu" aria-label="Close"></button>

‎site/src/assets/examples/navbars-offcanvas/index.astro‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ export const extra_css = ['navbars-offcanvas.css']
1212
<button class="navbar-toggler" type="button" data-bs-toggle="offcanvas" data-bs-target="#offcanvasNavbarDark" aria-controls="offcanvasNavbarDark" aria-label="Toggle navigation">
1313
<span class="navbar-toggler-icon"></span>
1414
</button>
15-
<div class="offcanvas offcanvas-end text-bg-dark" tabindex="-1" id="offcanvasNavbarDark" aria-labelledby="offcanvasNavbarDarkLabel">
15+
<div class="offcanvas offcanvas-end text-bg-dark" tabindex="-1" id="offcanvasNavbarDark">
1616
<div class="offcanvas-header">
1717
<h5 class="offcanvas-title" id="offcanvasNavbarDarkLabel">Offcanvas</h5>
1818
<button type="button" class="btn-close btn-close-white" data-bs-dismiss="offcanvas" aria-label="Close"></button>
@@ -54,7 +54,7 @@ export const extra_css = ['navbars-offcanvas.css']
5454
<button class="navbar-toggler" type="button" data-bs-toggle="offcanvas" data-bs-target="#offcanvasNavbarLight" aria-controls="offcanvasNavbarLight" aria-label="Toggle navigation">
5555
<span class="navbar-toggler-icon"></span>
5656
</button>
57-
<div class="offcanvas offcanvas-end" tabindex="-1" id="offcanvasNavbarLight" aria-labelledby="offcanvasNavbarLightLabel">
57+
<div class="offcanvas offcanvas-end" tabindex="-1" id="offcanvasNavbarLight">
5858
<div class="offcanvas-header">
5959
<h5 class="offcanvas-title" id="offcanvasNavbarLightLabel">Offcanvas</h5>
6060
<button type="button" class="btn-close" data-bs-dismiss="offcanvas" aria-label="Close"></button>
@@ -96,7 +96,7 @@ export const extra_css = ['navbars-offcanvas.css']
9696
<button class="navbar-toggler" type="button" data-bs-toggle="offcanvas" data-bs-target="#offcanvasNavbar2" aria-controls="offcanvasNavbar2" aria-label="Toggle navigation">
9797
<span class="navbar-toggler-icon"></span>
9898
</button>
99-
<div class="offcanvas offcanvas-end text-bg-dark" tabindex="-1" id="offcanvasNavbar2" aria-labelledby="offcanvasNavbar2Label">
99+
<div class="offcanvas offcanvas-end text-bg-dark" tabindex="-1" id="offcanvasNavbar2">
100100
<div class="offcanvas-header">
101101
<h5 class="offcanvas-title" id="offcanvasNavbar2Label">Offcanvas</h5>
102102
<button type="button" class="btn-close btn-close-white" data-bs-dismiss="offcanvas" aria-label="Close"></button>

‎site/src/assets/examples/product/index.astro‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const extra_css = ['product.css']
2525
<button class="navbar-toggler" type="button" data-bs-toggle="offcanvas" data-bs-target="#offcanvas" aria-controls="offcanvas" aria-label="Toggle navigation">
2626
<span class="navbar-toggler-icon"></span>
2727
</button>
28-
<div class="offcanvas offcanvas-end" tabindex="-1" id="offcanvas" aria-labelledby="offcanvasLabel">
28+
<div class="offcanvas offcanvas-end" tabindex="-1" id="offcanvas">
2929
<div class="offcanvas-header">
3030
<h5 class="offcanvas-title" id="offcanvasLabel">Aperture</h5>
3131
<button type="button" class="btn-close" data-bs-dismiss="offcanvas" aria-label="Close"></button>

‎site/src/components/header/Navigation.astro‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ const { addedIn, layout, title } = Astro.props
6565
class="offcanvas-lg offcanvas-end flex-grow-1"
6666
tabindex="-1"
6767
id="bdNavbar"
68-
aria-labelledby="bdNavbarOffcanvasLabel"
6968
>
7069
<div class="offcanvas-header px-4 pb-0">
7170
<h5 class="offcanvas-title text-white" id="bdNavbarOffcanvasLabel">Bootstrap</h5>

‎site/src/components/home/ComponentUtilities.astro‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ import Code from '@shortcodes/Code.astro'
4242
data-bs-toggle="tab"
4343
type="button"
4444
role="tab"
45+
aria-controls="fake-panel"
4546
aria-selected="true">Home</button
4647
>
4748
</li>
@@ -79,6 +80,7 @@ import Code from '@shortcodes/Code.astro'
7980
data-bs-toggle="tab"
8081
type="button"
8182
role="tab"
83+
aria-controls="fake-panel"
8284
aria-selected="true">Home</button
8385
>
8486
</li>
@@ -103,6 +105,7 @@ import Code from '@shortcodes/Code.astro'
103105
>
104106
</li>
105107
</ul>
108+
<div aria-hidden="true" role="tabpanel" id="fake-panel"></div>
106109
</div>
107110
<Code
108111
code={`<ul class="nav nav-pills nav-fill gap-2 p-1 small bg-primary rounded-5 shadow-sm" id="pillNav2" role="tablist" style="--bs-nav-link-color: var(--bs-white); --bs-nav-pills-link-active-color: var(--bs-primary); --bs-nav-pills-link-active-bg: var(--bs-white);">

0 commit comments

Comments
 (0)