🔧 fix(ci): restore git credentials for release job#472
Merged
gaborbernat merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
gaborbernat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zizmor security tool added
persist-credentials: falseto all checkout steps, which broke releases. The release job pushes version tags and changelog commits to the repository, but stripping credentials after checkout caused these operations to fail with authentication errors.Removing
persist-credentials: falsefrom the release job's checkout restores the ability to push. 🔐 Theartipackedwarning is suppressed with an inline ignore because it's a false positive in this context—the release job never uploads artifacts that could leak the persisted credentials. The build job (which does upload artifacts) correctly keepspersist-credentials: false.This change only affects the release workflow. Regular CI checks remain protected with credential stripping intact.